]> git.xonotic.org Git - xonotic/darkplaces.git/commitdiff
comment audio formats proraide/darkplaces_issue_145
authorMartin Taibr <taibr.martin@gmail.com>
Mon, 26 Aug 2019 18:48:29 +0000 (20:48 +0200)
committerMartin Taibr <taibr.martin@gmail.com>
Mon, 26 Aug 2019 18:48:29 +0000 (20:48 +0200)
snd_sdl.c

index 6de41d659f787b14cc99b93c67e1ed9d90fc6d69..d5cca85668d0c39bb61d7c73a6df2a334aaba34b 100644 (file)
--- a/snd_sdl.c
+++ b/snd_sdl.c
@@ -70,6 +70,7 @@ static void Buffer_Callback (void *userdata, Uint8 *stream, int len)
                        memcpy(&stream[PartialLength1], &snd_renderbuffer->ring[0], PartialLength2);
 
                        // As of SDL 2.0 buffer needs to be fully initialized, so fill leftover part with silence
+                       // FIXME this is another place that assumes 8bit is always unsigned and others always signed
                        memset(&stream[PartialLength1 + PartialLength2], snd_renderbuffer->format.width == 1 ? 0x80 : 0, len - (PartialLength1 + PartialLength2));
                }
                else
@@ -77,6 +78,7 @@ static void Buffer_Callback (void *userdata, Uint8 *stream, int len)
                        memcpy(stream, &snd_renderbuffer->ring[StartOffset * factor], FrameCount * factor);
 
                        // As of SDL 2.0 buffer needs to be fully initialized, so fill leftover part with silence
+                       // FIXME this is another place that assumes 8bit is always unsigned and others always signed
                        memset(&stream[FrameCount * factor], snd_renderbuffer->format.width == 1 ? 0x80 : 0, len - (FrameCount * factor));
                }