]> git.xonotic.org Git - xonotic/darkplaces.git/commitdiff
Add a Quake Live-style mouse acceleration mode.
authorFrank <franparpe@franparpe.org>
Sun, 15 Mar 2020 01:43:41 +0000 (21:43 -0400)
committerRudolf Polzer <divVerent@gmail.com>
Sun, 15 Mar 2020 01:48:44 +0000 (21:48 -0400)
Its cvars are m_accel_power*, and the cvar meanings are as close as possible
to the ezQuake implementation (as its source is available). Names differ though
due to conflicts with the current linear acceleration mode.

Original code by Frank <franparpe@franparpe.org>, cleanups by Rudolf Polzer <divVerent@xonotic.org>.
::stable-branch::merge=67692f92e177d44231df0d59833cee069e71eb9a

cl_input.c

index cae0e1250aabd5d6c9501123222d28d110920f9d..26e285540535bb76e5bc6be0efc60c6e09248280 100644 (file)
@@ -447,11 +447,15 @@ cvar_t cl_nopred = {CVAR_SAVE, "cl_nopred", "0", "(QWSV only) disables player mo
 cvar_t in_pitch_min = {0, "in_pitch_min", "-90", "how far you can aim upward (quake used -70)"};
 cvar_t in_pitch_max = {0, "in_pitch_max", "90", "how far you can aim downward (quake used 80)"};
 
-cvar_t m_filter = {CVAR_SAVE, "m_filter","0", "smoothes mouse movement, less responsive but smoother aiming"};
-cvar_t m_accelerate = {CVAR_SAVE, "m_accelerate","1", "mouse acceleration factor (try 2)"};
-cvar_t m_accelerate_minspeed = {CVAR_SAVE, "m_accelerate_minspeed","5000", "below this speed, no acceleration is done"};
-cvar_t m_accelerate_maxspeed = {CVAR_SAVE, "m_accelerate_maxspeed","10000", "above this speed, full acceleration is done"};
-cvar_t m_accelerate_filter = {CVAR_SAVE, "m_accelerate_filter","0.1", "mouse acceleration factor filtering"};
+cvar_t m_filter = {CVAR_SAVE, "m_filter","0", "smoothes mouse movement, less responsive but smoother aiming"}; 
+cvar_t m_accelerate = {CVAR_SAVE, "m_accelerate","1", "linear mouse acceleration factor (set to 1 to disable the linear acceleration and use only the power acceleration; set to 0 to disable all acceleration)"};
+cvar_t m_accelerate_minspeed = {CVAR_SAVE, "m_accelerate_minspeed","5000", "below this speed in px/s, no acceleration is done, with a linear slope between (applied only on linear acceleration)"};
+cvar_t m_accelerate_maxspeed = {CVAR_SAVE, "m_accelerate_maxspeed","10000", "above this speed in px/s, full acceleration is done, with a linear slope between (applied only on linear acceleration)"};
+cvar_t m_accelerate_filter = {CVAR_SAVE, "m_accelerate_filter","0", "linear mouse acceleration factor filtering lowpass constant in seconds (set to 0 for no filtering)"};
+cvar_t m_accelerate_power_offset = {CVAR_SAVE, "m_accelerate_power_offset","0", "below this speed in px/ms, no power acceleration is done"};
+cvar_t m_accelerate_power = {CVAR_SAVE, "m_accelerate_power","2", "acceleration power (must be above 1 to be useful)"};
+cvar_t m_accelerate_power_senscap = {CVAR_SAVE, "m_accelerate_power_senscap", "0", "maximum acceleration factor generated by power acceleration; use 0 for unbounded"};
+cvar_t m_accelerate_power_strength = {CVAR_SAVE, "m_accelerate_power_strength", "0", "strength of the power mouse acceleration effect"};
 
 cvar_t cl_netfps = {CVAR_SAVE, "cl_netfps","72", "how many input packets to send to server each second"};
 cvar_t cl_netrepeatinput = {CVAR_SAVE, "cl_netrepeatinput", "1", "how many packets in a row can be lost without movement issues when using cl_movement (technically how many input messages to repeat in each packet that have not yet been acknowledged by the server), only affects DP7 and later servers (Quake uses 0, QuakeWorld uses 2, and just for comparison Quake3 uses 1)"};
@@ -589,38 +593,88 @@ void CL_Input (void)
                }
        }
 
-       // apply m_accelerate if it is on
-       if(m_accelerate.value > 1)
+       // apply m_accelerate if it is on
+       if(m_accelerate.value > 0)
        {
+               float mouse_deltadist = sqrtf(in_mouse_x * in_mouse_x + in_mouse_y * in_mouse_y);
+               float speed = mouse_deltadist / cl.realframetime;
                static float averagespeed = 0;
-               float speed, f, mi, ma;
-
-               speed = sqrt(in_mouse_x * in_mouse_x + in_mouse_y * in_mouse_y) / cl.realframetime;
+               float f, mi, ma;
                if(m_accelerate_filter.value > 0)
-                       f = bound(0, cl.realframetime / m_accelerate_filter.value, 1);
+                       f = bound(0, cl.realframetime / m_accelerate_filter.value, 1);
                else
-                       f = 1;
+                       f = 1;
                averagespeed = speed * f + averagespeed * (1 - f);
 
-               mi = max(1, m_accelerate_minspeed.value);
-               ma = max(m_accelerate_minspeed.value + 1, m_accelerate_maxspeed.value);
-
-               if(averagespeed <= mi)
-               {
-                       f = 1;
-               }
-               else if(averagespeed >= ma)
+               // Note: this check is technically unnecessary, as everything in here cancels out if it is zero.
+               if (m_accelerate.value != 1.0f)
                {
-                       f = m_accelerate.value;
+                       // First do linear slope acceleration which was ripped "in
+                       // spirit" from many classic mouse driver implementations.
+                       // If m_accelerate.value == 1, this code does nothing at all.
+
+                       mi = max(1, m_accelerate_minspeed.value);
+                       ma = max(m_accelerate_minspeed.value + 1, m_accelerate_maxspeed.value);
+
+                       if(averagespeed <= mi)
+                       {
+                               f = 1;
+                       }
+                       else if(averagespeed >= ma)
+                       {
+                               f = m_accelerate.value;
+                       }
+                       else
+                       {
+                               f = averagespeed;
+                               f = (f - mi) / (ma - mi) * (m_accelerate.value - 1) + 1;
+                       }
+                       in_mouse_x *= f;
+                       in_mouse_y *= f;
                }
-               else
+
+               // Note: this check is technically unnecessary, as everything in here cancels out if it is zero.
+               if (m_accelerate_power_strength.value != 0.0f)
                {
-                       f = averagespeed;
-                       f = (f - mi) / (ma - mi) * (m_accelerate.value - 1) + 1;
-               }
+                       // Then do Quake Live-style power acceleration.
+                       // Note that this behavior REPLACES the usual
+                       // sensitivity, so we apply it but then dividie by
+                       // sensitivity.value so that the later multiplication
+                       // restores it again.
+                       float accelsens = 1.0f;
+                       float adjusted_speed_pxms = (averagespeed * 0.001f - m_accelerate_power_offset.value) * m_accelerate_power_strength.value;
+                       float inv_sensitivity = 1.0f / sensitivity.value;
+                       if (adjusted_speed_pxms > 0)
+                       {
+                               if (m_accelerate_power.value > 1.0f)
+                               {
+                                       // TODO: How does this interact with sensitivity changes? Is this intended?
+                                       // Currently: more sensitivity = less acceleration at same pixel speed.
+                                       accelsens += expf((m_accelerate_power.value - 1.0f) * logf(adjusted_speed_pxms)) * inv_sensitivity;
+                               }
+                               else
+                               {
+                                       // The limit of the then-branch for m_accelerate_power -> 1.
+                                       accelsens += inv_sensitivity;
+                                       // Note: QL had just accelsens = 1.0f.
+                                       // This is mathematically wrong though.
+                               }
+                       }
+                       else
+                       {
+                               // The limit of the then-branch for adjusted_speed -> 0.
+                               // accelsens += 0.0f;
+                       }
+                       if (m_accelerate_power_senscap.value > 0.0f && accelsens > m_accelerate_power_senscap.value * inv_sensitivity)
+                       {
+                               // TODO: How does this interact with sensitivity changes? Is this intended?
+                               // Currently: senscap is in absolute sensitivity units, so if senscap < sensitivity, it overrides.
+                               accelsens = m_accelerate_power_senscap.value * inv_sensitivity;
+                       }
 
-               in_mouse_x *= f;
-               in_mouse_y *= f;
+                       in_mouse_x *= accelsens;
+                       in_mouse_y *= accelsens;
+               }
        }
 
        // apply m_filter if it is on
@@ -2263,6 +2317,10 @@ void CL_InitInput (void)
        Cvar_RegisterVariable(&m_accelerate_minspeed);
        Cvar_RegisterVariable(&m_accelerate_maxspeed);
        Cvar_RegisterVariable(&m_accelerate_filter);
+       Cvar_RegisterVariable(&m_accelerate_power);
+       Cvar_RegisterVariable(&m_accelerate_power_offset);
+       Cvar_RegisterVariable(&m_accelerate_power_senscap);
+       Cvar_RegisterVariable(&m_accelerate_power_strength);
 
        Cvar_RegisterVariable(&cl_netfps);
        Cvar_RegisterVariable(&cl_netrepeatinput);