]> git.xonotic.org Git - xonotic/darkplaces.git/blobdiff - cmd.c
Call cvar callbacks after the cvar is set. Potentially fixes heap corruption.
[xonotic/darkplaces.git] / cmd.c
diff --git a/cmd.c b/cmd.c
index d2369157273c4a0c7a794989e0c6a56999f69de1..ea0b608eecfab77ade1a7bca311d3ce0ca4e85dc 100644 (file)
--- a/cmd.c
+++ b/cmd.c
@@ -23,7 +23,6 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 #include "thread.h"
 
 cmd_state_t cmd_client;
-cmd_state_t cmd_clientfromserver;
 cmd_state_t cmd_server;
 cmd_state_t cmd_serverfromclient;
 
@@ -37,7 +36,6 @@ cmd_iter_t;
 
 static cmd_iter_t cmd_iter_all[] = {
        {&cmd_client},
-       {&cmd_clientfromserver},
        {&cmd_server},
        {&cmd_serverfromclient},
        {NULL},
@@ -239,11 +237,11 @@ static void Cbuf_Execute_Deferred (cmd_state_t *cmd)
 {
        cmddeferred_t *defcmd, *prev;
        double eat;
-       if (realtime - cmd->deferred_oldrealtime < 0 || realtime - cmd->deferred_oldrealtime > 1800) cmd->deferred_oldrealtime = realtime;
-       eat = realtime - cmd->deferred_oldrealtime;
+       if (host.realtime - cmd->deferred_oldrealtime < 0 || host.realtime - cmd->deferred_oldrealtime > 1800) cmd->deferred_oldrealtime = host.realtime;
+       eat = host.realtime - cmd->deferred_oldrealtime;
        if (eat < (1.0 / 120.0))
                return;
-       cmd->deferred_oldrealtime = realtime;
+       cmd->deferred_oldrealtime = host.realtime;
        prev = NULL;
        defcmd = cmd->deferred_list;
        while(defcmd)
@@ -397,8 +395,6 @@ void Cbuf_Frame(cmd_state_t *cmd)
 ==============================================================================
 */
 
-extern qboolean host_init;
-
 /*
 ===============
 Cmd_StuffCmds_f
@@ -414,9 +410,9 @@ static void Cmd_StuffCmds_f (cmd_state_t *cmd)
        int             i, j, l;
        // this is for all commandline options combined (and is bounds checked)
        char    build[MAX_INPUTLINE];
-
+       
        // come back later so we don't crash
-       if(host_init)
+       if(host.state == host_init)
                return;
 
        if (Cmd_Argc (cmd) != 1)
@@ -432,28 +428,28 @@ static void Cmd_StuffCmds_f (cmd_state_t *cmd)
        host_stuffcmdsrun = true;
        build[0] = 0;
        l = 0;
-       for (i = 0;i < com_argc;i++)
+       for (i = 0;i < sys.argc;i++)
        {
-               if (com_argv[i] && com_argv[i][0] == '+' && (com_argv[i][1] < '0' || com_argv[i][1] > '9') && l + strlen(com_argv[i]) - 1 <= sizeof(build) - 1)
+               if (sys.argv[i] && sys.argv[i][0] == '+' && (sys.argv[i][1] < '0' || sys.argv[i][1] > '9') && l + strlen(sys.argv[i]) - 1 <= sizeof(build) - 1)
                {
                        j = 1;
-                       while (com_argv[i][j])
-                               build[l++] = com_argv[i][j++];
+                       while (sys.argv[i][j])
+                               build[l++] = sys.argv[i][j++];
                        i++;
-                       for (;i < com_argc;i++)
+                       for (;i < sys.argc;i++)
                        {
-                               if (!com_argv[i])
+                               if (!sys.argv[i])
                                        continue;
-                               if ((com_argv[i][0] == '+' || com_argv[i][0] == '-') && (com_argv[i][1] < '0' || com_argv[i][1] > '9'))
+                               if ((sys.argv[i][0] == '+' || sys.argv[i][0] == '-') && (sys.argv[i][1] < '0' || sys.argv[i][1] > '9'))
                                        break;
-                               if (l + strlen(com_argv[i]) + 4 > sizeof(build) - 1)
+                               if (l + strlen(sys.argv[i]) + 4 > sizeof(build) - 1)
                                        break;
                                build[l++] = ' ';
-                               if (strchr(com_argv[i], ' '))
+                               if (strchr(sys.argv[i], ' '))
                                        build[l++] = '\"';
-                               for (j = 0;com_argv[i][j];j++)
-                                       build[l++] = com_argv[i][j];
-                               if (strchr(com_argv[i], ' '))
+                               for (j = 0;sys.argv[i][j];j++)
+                                       build[l++] = sys.argv[i][j];
+                               if (strchr(sys.argv[i], ' '))
                                        build[l++] = '\"';
                        }
                        build[l++] = '\n';
@@ -661,6 +657,7 @@ static void Cmd_Exec(cmd_state_t *cmd, const char *filename)
 "sv_gameplayfix_q2airaccelerate 1\n"
 "sv_gameplayfix_stepmultipletimes 1\n"
 "csqc_polygons_defaultmaterial_nocullface 1\n"
+"con_chatsound_team_mask 13\n"
                                );
                        break;
                case GAME_XONOTIC:
@@ -668,6 +665,8 @@ static void Cmd_Exec(cmd_state_t *cmd, const char *filename)
                        // compatibility for versions prior to 2020-05-25, this can be overridden in newer versions to get the default behavior and be consistent with FTEQW engine
                        Cbuf_InsertText(cmd, "\n"
 "csqc_polygons_defaultmaterial_nocullface 1\n"
+"con_chatsound_team_mask 13\n"
+"sv_gameplayfix_customstats 1\n"
                                );
                        break;
                // Steel Storm: Burning Retribution csqc misinterprets CSQC_InputEvent if type is a value other than 0 or 1
@@ -1434,7 +1433,7 @@ static void Cmd_Apropos_f(cmd_state_t *cmd)
                partial = Cmd_Args(cmd);
        else
        {
-               Con_Printf("usage: apropos <string>\n");
+               Con_Printf("usage: %s <string>\n",Cmd_Argv(cmd, 0));
                return;
        }
 
@@ -1511,89 +1510,59 @@ void Cmd_Init(void)
        // client console can see server cvars because the user may start a server
        cmd_client.cvars = &cvars_all;
        cmd_client.cvars_flagsmask = CVAR_CLIENT | CVAR_SERVER;
+       cmd_client.cmd_flags = CMD_CLIENT | CMD_CLIENT_FROM_SERVER | CMD_SERVER_FROM_CLIENT;
        cmd_client.userdefined = &cmd_userdefined_all;
-       // stuffcmd from server has access to the reasonable client things, but it probably doesn't need to access the client's server-only cvars
-       cmd_clientfromserver.cvars = &cvars_all;
-       cmd_clientfromserver.cvars_flagsmask = CVAR_CLIENT;
-       cmd_clientfromserver.userdefined = &cmd_userdefined_all;
        // dedicated server console can only see server cvars, there is no client
        cmd_server.cvars = &cvars_all;
        cmd_server.cvars_flagsmask = CVAR_SERVER;
+       cmd_server.cmd_flags = CMD_SERVER;
        cmd_server.userdefined = &cmd_userdefined_all;
        // server commands received from clients have no reason to access cvars, cvar expansion seems perilous.
        cmd_serverfromclient.cvars = &cvars_null;
        cmd_serverfromclient.cvars_flagsmask = 0;
+       cmd_serverfromclient.cmd_flags = CMD_SERVER_FROM_CLIENT | CMD_USERINFO;
        cmd_serverfromclient.userdefined = &cmd_userdefined_null;
-}
 
-void Cmd_Init_Commands(qboolean dedicated_server)
-{
 //
 // register our commands
 //
        // client-only commands
-       Cmd_AddCommand(&cmd_client, "cmd", Cmd_ForwardToServer_f, "send a console commandline to the server (used by some mods)");
-       Cmd_AddCommand(&cmd_clientfromserver, "cmd", Cmd_ForwardToServer_f, "send a console commandline to the server (used by some mods)");
-       Cmd_AddCommand(&cmd_client, "wait", Cmd_Wait_f, "make script execution wait for next rendered frame");
-       Cmd_AddCommand(&cmd_client, "cprint", Cmd_Centerprint_f, "print something at the screen center");
+       Cmd_AddCommand(CMD_CLIENT | CMD_CLIENT_FROM_SERVER, "cmd", Cmd_ForwardToServer_f, "send a console commandline to the server (used by some mods)");
+       Cmd_AddCommand(CMD_SHARED, "wait", Cmd_Wait_f, "make script execution wait for next rendered frame");
+       Cmd_AddCommand(CMD_CLIENT, "cprint", Cmd_Centerprint_f, "print something at the screen center");
 
        // maintenance commands used for upkeep of cvars and saved configs
-       Cmd_AddCommand(&cmd_client, "stuffcmds", Cmd_StuffCmds_f, "execute commandline parameters (must be present in quake.rc script)");
-       Cmd_AddCommand(&cmd_client, "cvar_lockdefaults", Cvar_LockDefaults_f, "stores the current values of all cvars into their default values, only used once during startup after parsing default.cfg");
-       Cmd_AddCommand(&cmd_client, "cvar_resettodefaults_all", Cvar_ResetToDefaults_All_f, "sets all cvars to their locked default values");
-       Cmd_AddCommand(&cmd_client, "cvar_resettodefaults_nosaveonly", Cvar_ResetToDefaults_NoSaveOnly_f, "sets all non-saved cvars to their locked default values (variables that will not be saved to config.cfg)");
-       Cmd_AddCommand(&cmd_client, "cvar_resettodefaults_saveonly", Cvar_ResetToDefaults_SaveOnly_f, "sets all saved cvars to their locked default values (variables that will be saved to config.cfg)");
-       Cmd_AddCommand(&cmd_server, "stuffcmds", Cmd_StuffCmds_f, "execute commandline parameters (must be present in quake.rc script)");
-       Cmd_AddCommand(&cmd_server, "cvar_lockdefaults", Cvar_LockDefaults_f, "stores the current values of all cvars into their default values, only used once during startup after parsing default.cfg");
-       Cmd_AddCommand(&cmd_server, "cvar_resettodefaults_all", Cvar_ResetToDefaults_All_f, "sets all cvars to their locked default values");
-       Cmd_AddCommand(&cmd_server, "cvar_resettodefaults_nosaveonly", Cvar_ResetToDefaults_NoSaveOnly_f, "sets all non-saved cvars to their locked default values (variables that will not be saved to config.cfg)");
-       Cmd_AddCommand(&cmd_server, "cvar_resettodefaults_saveonly", Cvar_ResetToDefaults_SaveOnly_f, "sets all saved cvars to their locked default values (variables that will be saved to config.cfg)");
+       Cmd_AddCommand(CMD_SHARED, "stuffcmds", Cmd_StuffCmds_f, "execute commandline parameters (must be present in quake.rc script)");
+       Cmd_AddCommand(CMD_SHARED, "cvar_lockdefaults", Cvar_LockDefaults_f, "stores the current values of all cvars into their default values, only used once during startup after parsing default.cfg");
+       Cmd_AddCommand(CMD_SHARED, "cvar_resettodefaults_all", Cvar_ResetToDefaults_All_f, "sets all cvars to their locked default values");
+       Cmd_AddCommand(CMD_SHARED, "cvar_resettodefaults_nosaveonly", Cvar_ResetToDefaults_NoSaveOnly_f, "sets all non-saved cvars to their locked default values (variables that will not be saved to config.cfg)");
+       Cmd_AddCommand(CMD_SHARED, "cvar_resettodefaults_saveonly", Cvar_ResetToDefaults_SaveOnly_f, "sets all saved cvars to their locked default values (variables that will be saved to config.cfg)");
 
        // general console commands used in multiple environments
-       Cmd_AddCommand(&cmd_client, "exec", Cmd_Exec_f, "execute a script file");
-       Cmd_AddCommand(&cmd_client, "echo",Cmd_Echo_f, "print a message to the console (useful in scripts)");
-       Cmd_AddCommand(&cmd_client, "alias",Cmd_Alias_f, "create a script function (parameters are passed in as $X (being X a number), $* for all parameters, $X- for all parameters starting from $X). Without arguments show the list of all alias");
-       Cmd_AddCommand(&cmd_client, "unalias",Cmd_UnAlias_f, "remove an alias");
-       Cmd_AddCommand(&cmd_client, "set", Cvar_Set_f, "create or change the value of a console variable");
-       Cmd_AddCommand(&cmd_client, "seta", Cvar_SetA_f, "create or change the value of a console variable that will be saved to config.cfg");
-       Cmd_AddCommand(&cmd_client, "unset", Cvar_Del_f, "delete a cvar (does not work for static ones like _cl_name, or read-only ones)");
-       Cmd_AddCommand(&cmd_clientfromserver, "exec", Cmd_Exec_f, "execute a script file");
-       Cmd_AddCommand(&cmd_clientfromserver, "echo", Cmd_Echo_f, "print a message to the console (useful in scripts)");
-       Cmd_AddCommand(&cmd_clientfromserver, "alias", Cmd_Alias_f, "create a script function (parameters are passed in as $X (being X a number), $* for all parameters, $X- for all parameters starting from $X). Without arguments show the list of all alias");
-       Cmd_AddCommand(&cmd_clientfromserver, "unalias", Cmd_UnAlias_f, "remove an alias");
-       Cmd_AddCommand(&cmd_clientfromserver, "set", Cvar_Set_f, "create or change the value of a console variable");
-       Cmd_AddCommand(&cmd_clientfromserver, "seta", Cvar_SetA_f, "create or change the value of a console variable that will be saved to config.cfg");
-       Cmd_AddCommand(&cmd_clientfromserver, "unset", Cvar_Del_f, "delete a cvar (does not work for static ones like _cl_name, or read-only ones)");
-       Cmd_AddCommand(&cmd_server, "exec", Cmd_Exec_f, "execute a script file");
-       Cmd_AddCommand(&cmd_server, "echo", Cmd_Echo_f, "print a message to the console (useful in scripts)");
-       Cmd_AddCommand(&cmd_server, "alias", Cmd_Alias_f, "create a script function (parameters are passed in as $X (being X a number), $* for all parameters, $X- for all parameters starting from $X). Without arguments show the list of all alias");
-       Cmd_AddCommand(&cmd_server, "unalias", Cmd_UnAlias_f, "remove an alias");
-       Cmd_AddCommand(&cmd_server, "set", Cvar_Set_f, "create or change the value of a console variable");
-       Cmd_AddCommand(&cmd_server, "seta", Cvar_SetA_f, "create or change the value of a console variable that will be saved to config.cfg");
-       Cmd_AddCommand(&cmd_server, "unset", Cvar_Del_f, "delete a cvar (does not work for static ones like _cl_name, or read-only ones)");
+       Cmd_AddCommand(CMD_SHARED, "exec", Cmd_Exec_f, "execute a script file");
+       Cmd_AddCommand(CMD_SHARED, "echo",Cmd_Echo_f, "print a message to the console (useful in scripts)");
+       Cmd_AddCommand(CMD_SHARED, "alias",Cmd_Alias_f, "create a script function (parameters are passed in as $X (being X a number), $* for all parameters, $X- for all parameters starting from $X). Without arguments show the list of all alias");
+       Cmd_AddCommand(CMD_SHARED, "unalias",Cmd_UnAlias_f, "remove an alias");
+       Cmd_AddCommand(CMD_SHARED, "set", Cvar_Set_f, "create or change the value of a console variable");
+       Cmd_AddCommand(CMD_SHARED, "seta", Cvar_SetA_f, "create or change the value of a console variable that will be saved to config.cfg");
+       Cmd_AddCommand(CMD_SHARED, "unset", Cvar_Del_f, "delete a cvar (does not work for static ones like _cl_name, or read-only ones)");
 
 #ifdef FILLALLCVARSWITHRUBBISH
-       Cmd_AddCommand(&cmd_client, "fillallcvarswithrubbish", Cvar_FillAll_f, "fill all cvars with a specified number of characters to provoke buffer overruns");
-       Cmd_AddCommand(&cmd_server, "fillallcvarswithrubbish", Cvar_FillAll_f, "fill all cvars with a specified number of characters to provoke buffer overruns");
+       Cmd_AddCommand(CMD_SHARED, "fillallcvarswithrubbish", Cvar_FillAll_f, "fill all cvars with a specified number of characters to provoke buffer overruns");
 #endif /* FILLALLCVARSWITHRUBBISH */
 
        // 2000-01-09 CmdList, CvarList commands By Matthias "Maddes" Buecher
        // Added/Modified by EvilTypeGuy eviltypeguy@qeradiant.com
-       Cmd_AddCommand(&cmd_client, "cmdlist", Cmd_List_f, "lists all console commands beginning with the specified prefix or matching the specified wildcard pattern");
-       Cmd_AddCommand(&cmd_client, "cvarlist", Cvar_List_f, "lists all console variables beginning with the specified prefix or matching the specified wildcard pattern");
-       Cmd_AddCommand(&cmd_client, "apropos", Cmd_Apropos_f, "lists all console variables/commands/aliases containing the specified string in the name or description");
-       Cmd_AddCommand(&cmd_server, "cmdlist", Cmd_List_f, "lists all console commands beginning with the specified prefix or matching the specified wildcard pattern");
-       Cmd_AddCommand(&cmd_server, "cvarlist", Cvar_List_f, "lists all console variables beginning with the specified prefix or matching the specified wildcard pattern");
-       Cmd_AddCommand(&cmd_server, "apropos", Cmd_Apropos_f, "lists all console variables/commands/aliases containing the specified string in the name or description");
+       Cmd_AddCommand(CMD_SHARED, "cmdlist", Cmd_List_f, "lists all console commands beginning with the specified prefix or matching the specified wildcard pattern");
+       Cmd_AddCommand(CMD_SHARED, "cvarlist", Cvar_List_f, "lists all console variables beginning with the specified prefix or matching the specified wildcard pattern");
+       Cmd_AddCommand(CMD_SHARED, "apropos", Cmd_Apropos_f, "lists all console variables/commands/aliases containing the specified string in the name or description");
+       Cmd_AddCommand(CMD_SHARED, "find", Cmd_Apropos_f, "lists all console variables/commands/aliases containing the specified string in the name or description");
 
-       Cmd_AddCommand(&cmd_client, "defer", Cmd_Defer_f, "execute a command in the future");
-       Cmd_AddCommand(&cmd_server, "defer", Cmd_Defer_f, "execute a command in the future");
+       Cmd_AddCommand(CMD_SHARED, "defer", Cmd_Defer_f, "execute a command in the future");
 
        // DRESK - 5/14/06
        // Support Doom3-style Toggle Command
-       Cmd_AddCommand(&cmd_client, "toggle", Cmd_Toggle_f, "toggles a console variable's values (use for more info)");
-       Cmd_AddCommand(&cmd_server, "toggle", Cmd_Toggle_f, "toggles a console variable's values (use for more info)");
-       Cmd_AddCommand(&cmd_clientfromserver, "toggle", Cmd_Toggle_f, "toggles a console variable's values (use for more info)");
+       Cmd_AddCommand(CMD_SHARED | CMD_CLIENT_FROM_SERVER, "toggle", Cmd_Toggle_f, "toggles a console variable's values (use for more info)");
 }
 
 /*
@@ -1699,7 +1668,7 @@ static void Cmd_TokenizeString (cmd_state_t *cmd, const char *text)
                        l = (int)strlen(com_token) + 1;
                        if (cmd->tokenizebufferpos + l > CMD_TOKENIZELENGTH)
                        {
-                               Con_Printf("Cmd_TokenizeString: ran out of %i character buffer space for command arguements\n", CMD_TOKENIZELENGTH);
+                               Con_Printf("Cmd_TokenizeString: ran out of %i character buffer space for command arguments\n", CMD_TOKENIZELENGTH);
                                break;
                        }
                        memcpy (cmd->tokenizebuffer + cmd->tokenizebufferpos, com_token, l);
@@ -1716,77 +1685,97 @@ static void Cmd_TokenizeString (cmd_state_t *cmd, const char *text)
 Cmd_AddCommand
 ============
 */
-void Cmd_AddCommand(cmd_state_t *cmd, const char *cmd_name, xcommand_t function, const char *description)
+void Cmd_AddCommand(int flags, const char *cmd_name, xcommand_t function, const char *description)
 {
        cmd_function_t *func;
        cmd_function_t *prev, *current;
+       cmd_state_t *cmd;
+       xcommand_t save = NULL;
+       int i;
 
-// fail if the command is a variable name
-       if (Cvar_FindVar(cmd->cvars, cmd_name, ~0))
-       {
-               Con_Printf("Cmd_AddCommand: %s already defined as a var\n", cmd_name);
-               return;
-       }
-
-       if (function)
+       for (i = 0; i < 3; i++)
        {
-               // fail if the command already exists in this interpreter
-               for (func = cmd->engine_functions; func; func = func->next)
+               cmd = cmd_iter_all[i].cmd;
+               if (flags & cmd->cmd_flags)
                {
-                       if (!strcmp(cmd_name, func->name))
+                       if(cmd == &cmd_client && (flags & CMD_SERVER_FROM_CLIENT) && !(flags & CMD_CLIENT))
                        {
-                               Con_Printf("Cmd_AddCommand: %s already defined\n", cmd_name);
+                               save = function;
+                               function = Cmd_ForwardToServer_f;
+                       }
+                       // fail if the command is a variable name
+                       if (Cvar_FindVar(cmd->cvars, cmd_name, ~0))
+                       {
+                               Con_Printf("Cmd_AddCommand: %s already defined as a var\n", cmd_name);
                                return;
                        }
-               }
 
-               func = (cmd_function_t *)Mem_Alloc(cmd->mempool, sizeof(cmd_function_t));
-               func->name = cmd_name;
-               func->function = function;
-               func->description = description;
-               func->next = cmd->engine_functions;
-
-               // insert it at the right alphanumeric position
-               for (prev = NULL, current = cmd->engine_functions; current && strcmp(current->name, func->name) < 0; prev = current, current = current->next)
-                       ;
-               if (prev) {
-                       prev->next = func;
-               }
-               else {
-                       cmd->engine_functions = func;
-               }
-               func->next = current;
-       }
-       else
-       {
-               // mark csqcfunc if the function already exists in the csqc_functions list
-               for (func = cmd->userdefined->csqc_functions; func; func = func->next)
-               {
-                       if (!strcmp(cmd_name, func->name))
+                       if (function)
                        {
-                               func->csqcfunc = true; //[515]: csqc
-                               return;
+                               // fail if the command already exists in this interpreter
+                               for (func = cmd->engine_functions; func; func = func->next)
+                               {
+                                       if (!strcmp(cmd_name, func->name))
+                                       {
+                                               Con_Printf("Cmd_AddCommand: %s already defined\n", cmd_name);
+                                               goto next;
+                                       }
+                               }
+
+                               func = (cmd_function_t *)Mem_Alloc(cmd->mempool, sizeof(cmd_function_t));
+                               func->flags = flags;
+                               func->name = cmd_name;
+                               func->function = function;
+                               func->description = description;
+                               func->next = cmd->engine_functions;
+
+                               // insert it at the right alphanumeric position
+                               for (prev = NULL, current = cmd->engine_functions; current && strcmp(current->name, func->name) < 0; prev = current, current = current->next)
+                                       ;
+                               if (prev) {
+                                       prev->next = func;
+                               }
+                               else {
+                                       cmd->engine_functions = func;
+                               }
+                               func->next = current;
                        }
-               }
+                       else
+                       {
+                               // mark csqcfunc if the function already exists in the csqc_functions list
+                               for (func = cmd->userdefined->csqc_functions; func; func = func->next)
+                               {
+                                       if (!strcmp(cmd_name, func->name))
+                                       {
+                                               func->csqcfunc = true; //[515]: csqc
+                                               continue;
+                                       }
+                               }
 
 
-               func = (cmd_function_t *)Mem_Alloc(cmd->mempool, sizeof(cmd_function_t));
-               func->name = cmd_name;
-               func->function = function;
-               func->description = description;
-               func->csqcfunc = true; //[515]: csqc
-               func->next = cmd->userdefined->csqc_functions;
+                               func = (cmd_function_t *)Mem_Alloc(cmd->mempool, sizeof(cmd_function_t));
+                               func->name = cmd_name;
+                               func->function = function;
+                               func->description = description;
+                               func->csqcfunc = true; //[515]: csqc
+                               func->next = cmd->userdefined->csqc_functions;
 
-               // insert it at the right alphanumeric position
-               for (prev = NULL, current = cmd->userdefined->csqc_functions; current && strcmp(current->name, func->name) < 0; prev = current, current = current->next)
-                       ;
-               if (prev) {
-                       prev->next = func;
-               }
-               else {
-                       cmd->userdefined->csqc_functions = func;
+                               // insert it at the right alphanumeric position
+                               for (prev = NULL, current = cmd->userdefined->csqc_functions; current && strcmp(current->name, func->name) < 0; prev = current, current = current->next)
+                                       ;
+                               if (prev) {
+                                       prev->next = func;
+                               }
+                               else {
+                                       cmd->userdefined->csqc_functions = func;
+                               }
+                               func->next = current;
+                       }
+                       if (save)
+                               function = save;
                }
-               func->next = current;
+next:
+               continue;
        }
 }
 
@@ -2027,6 +2016,8 @@ void Cmd_ClearCSQCCommands (cmd_state_t *cmd)
        }
 }
 
+extern cvar_t sv_cheats;
+
 /*
 ============
 Cmd_ExecuteString
@@ -2077,7 +2068,10 @@ void Cmd_ExecuteString (cmd_state_t *cmd, const char *text, cmd_source_t src, qb
                        case src_client:
                                if (func->function)
                                {
-                                       func->function(cmd);
+                                       if((func->flags & CMD_CHEAT) && !sv_cheats.integer)
+                                               SV_ClientPrintf("No cheats allowed. The server must have sv_cheats set to 1\n");
+                                       else
+                                               func->function(cmd);
                                        goto done;
                                }
                        }
@@ -2103,13 +2097,8 @@ void Cmd_ExecuteString (cmd_state_t *cmd, const char *text, cmd_source_t src, qb
        }
 
 // check cvars
-       if (!Cvar_Command(cmd) && host_framecount > 0) {
-               if (cmd == &cmd_clientfromserver) {
-                       Con_Printf("Server tried to execute \"%s\"\n", Cmd_Argv(cmd, 0));
-               } else {
-                       Con_Printf("Unknown command \"%s\"\n", Cmd_Argv(cmd, 0));
-               }
-       }
+       if (!Cvar_Command(cmd) && host.framecount > 0)
+               Con_Printf("Unknown command \"%s\"\n", Cmd_Argv(cmd, 0));
 done:
        cmd->tokenizebufferpos = oldpos;
        if (lockmutex)