CINIT(PRIVATE, OBJECTPOINT, 103),
CINIT(LOW_SPEED_LIMIT, LONG , 19),
CINIT(LOW_SPEED_TIME, LONG, 20),
+ CINIT(PROTOCOLS, LONG, 181),
+ CINIT(REDIR_PROTOCOLS, LONG, 182),
}
CURLoption;
+#define CURLPROTO_HTTP (1<<0)
+#define CURLPROTO_HTTPS (1<<1)
+#define CURLPROTO_FTP (1<<2)
typedef enum
{
CURLINFO_TEXT = 0,
CURLMsg;
static void (*qcurl_global_init) (long flags);
-static void (*qcurl_global_cleanup) ();
+static void (*qcurl_global_cleanup) (void);
-static CURL * (*qcurl_easy_init) ();
+static CURL * (*qcurl_easy_init) (void);
static void (*qcurl_easy_cleanup) (CURL *handle);
static CURLcode (*qcurl_easy_setopt) (CURL *handle, CURLoption option, ...);
static CURLcode (*qcurl_easy_getinfo) (CURL *handle, CURLINFO info, ...);
static const char * (*qcurl_easy_strerror) (CURLcode);
-static CURLM * (*qcurl_multi_init) ();
+static CURLM * (*qcurl_multi_init) (void);
static CURLMcode (*qcurl_multi_perform) (CURLM *multi_handle, int *running_handles);
static CURLMcode (*qcurl_multi_add_handle) (CURLM *multi_handle, CURL *easy_handle);
static CURLMcode (*qcurl_multi_remove_handle) (CURLM *multi_handle, CURL *easy_handle);
typedef struct downloadinfo_s
{
- char filename[MAX_QPATH];
+ char filename[MAX_OSPATH];
char url[1024];
char referer[256];
qfile_t *stream;
Clears the "will disconnect on failure" flags.
====================
*/
-void Curl_Clear_forthismap()
+void Curl_Clear_forthismap(void)
{
downloadinfo *di;
if(noclear)
Returns true if a download needed for the current game is running.
====================
*/
-qboolean Curl_Have_forthismap()
+qboolean Curl_Have_forthismap(void)
{
- return numdownloads_added;
+ return numdownloads_added != 0;
}
-void Curl_Register_predownload()
+void Curl_Register_predownload(void)
{
Curl_CommandWhenDone("cl_begindownloads");
Curl_CommandWhenError("cl_begindownloads");
All downloads finished, at least one success since connect, no single failure
-> execute the command.
*/
-static void Curl_CheckCommandWhenDone()
+static void Curl_CheckCommandWhenDone(void)
{
if(!curl_dll)
return;
code from libcurl, or 0, if another error has occurred.
====================
*/
+static qboolean Curl_Begin(const char *URL, const char *name, qboolean ispak, qboolean forthismap, unsigned char *buf, size_t bufsize, curl_callback_t callback, void *cbdata);
static void Curl_EndDownload(downloadinfo *di, CurlStatus status, CURLcode error)
{
qboolean ok = false;
qcurl_easy_cleanup(di->curle);
}
- if(ok && !di->bytes_received)
+ if(!di->callback && ok && !di->bytes_received)
{
Con_Printf("ERROR: empty file\n");
ok = false;
FS_Close(di->stream);
if(ok && di->ispak)
+ {
ok = FS_AddPack(di->filename, NULL, true);
+ if(!ok)
+ {
+ // pack loading failed?
+ // this is critical
+ // better clear the file again...
+ di->stream = FS_OpenRealFile(di->filename, "wb", false);
+ FS_Close(di->stream);
+
+ if(di->startpos && !di->callback)
+ {
+ // this was a resume?
+ // then try to redownload it without reporting the error
+ Curl_Begin(di->url, di->filename, di->ispak, di->forthismap, NULL, 0, NULL, NULL);
+ di->forthismap = false; // don't count the error
+ }
+ }
+ }
if(di->prev)
di->prev->next = di->next;
up to a maximum number of cl_curl_maxdownloads are running.
====================
*/
-static void CheckPendingDownloads()
+static void CheckPendingDownloads(void)
{
if(!curl_dll)
return;
qcurl_easy_setopt(di->curle, CURLOPT_LOW_SPEED_TIME, (long) 45);
qcurl_easy_setopt(di->curle, CURLOPT_WRITEDATA, (void *) di);
qcurl_easy_setopt(di->curle, CURLOPT_PRIVATE, (void *) di);
+ qcurl_easy_setopt(di->curle, CURLOPT_PROTOCOLS, CURLPROTO_HTTP | CURLPROTO_HTTPS | CURLPROTO_FTP);
+ if(qcurl_easy_setopt(di->curle, CURLOPT_REDIR_PROTOCOLS, CURLPROTO_HTTP | CURLPROTO_HTTPS | CURLPROTO_FTP) != CURLE_OK)
+ {
+ Con_Printf("^1WARNING:^7 for security reasons, please upgrade to libcurl 7.19.4 or above. In a later version of DarkPlaces, HTTP redirect support will be disabled for this libcurl version.\n");
+ //qcurl_easy_setopt(di->curle, CURLOPT_FOLLOWLOCATION, 0);
+ }
+
qcurl_multi_add_handle(curlm, di->curle);
di->started = true;
++numdownloads;
On Win32, this must be called AFTER WSAStartup has been done!
====================
*/
-void Curl_Init()
+void Curl_Init(void)
{
CURL_OpenLibrary();
if(!curl_dll)
Surprise... closes all the stuff. Please do this BEFORE shutting down LHNET.
====================
*/
-void Curl_ClearRequirements();
-void Curl_Shutdown()
+void Curl_ClearRequirements(void);
+void Curl_Shutdown(void)
{
if(!curl_dll)
return;
}
else
{
- char fn[MAX_QPATH];
+ char fn[MAX_OSPATH];
const char *p, *q;
size_t length;
downloadinfo *di;
}
else
{
- qfile_t *f = FS_OpenVirtualFile(fn, false);
+ qfile_t *f = FS_OpenRealFile(fn, "rb", false);
if(f)
{
char buf[4] = {0};
// URL scheme (so one can't read local files using file://)
if(strncmp(URL, "http://", 7) && strncmp(URL, "ftp://", 6) && strncmp(URL, "https://", 8))
{
- Con_Printf("Curl_Begin(\"%s\")): nasty URL scheme rejected\n", URL);
+ Con_Printf("Curl_Begin(\"%s\"): nasty URL scheme rejected\n", URL);
return false;
}
di->startpos = 0;
di->curle = NULL;
di->started = false;
- di->ispak = ispak;
+ di->ispak = (ispak && !buf);
di->bytes_received = 0;
di->next = downloads;
di->prev = NULL;
blocking.
====================
*/
-void Curl_Run()
+void Curl_Run(void)
{
noclear = FALSE;
case 4: // e.g. 404?
case 5: // e.g. 500?
failed = CURL_DOWNLOAD_SERVERERROR;
- result = code;
+ result = (CURLcode) code;
break;
}
}
Stops ALL downloads.
====================
*/
-void Curl_CancelAll()
+void Curl_CancelAll(void)
{
if(!curl_dll)
return;
returns true iff there is a download running.
====================
*/
-qboolean Curl_Running()
+qboolean Curl_Running(void)
{
if(!curl_dll)
return false;
double length;
qcurl_easy_getinfo(di->curle, CURLINFO_CONTENT_LENGTH_DOWNLOAD, &length);
if(length > 0)
- return di->bytes_received / length;
+ return (di->startpos + di->bytes_received) / (di->startpos + length);
else
return 0;
}
====================
*/
// TODO rewrite using Curl_GetDownloadInfo?
-static void Curl_Info_f()
+static void Curl_Info_f(void)
{
downloadinfo *di;
if(!curl_dll)
typedef struct requirement_s
{
struct requirement_s *next;
- char filename[MAX_QPATH];
+ char filename[MAX_OSPATH];
}
requirement;
static requirement *requirements = NULL;
This should be called at every map change.
====================
*/
-void Curl_ClearRequirements()
+void Curl_ClearRequirements(void)
{
const char *p;
while(requirements)
curl --finish_autodownload
====================
*/
-void Curl_SendRequirements()
+void Curl_SendRequirements(void)
{
// for each requirement, find the pack name
char sendbuffer[4096] = "";