#include "quakedef.h"
#define MAX_ALIAS_NAME 32
+// this is the largest script file that can be executed in one step
+// LordHavoc: inreased this from 8192 to 32768
+#define CMDBUFSIZE 32768
+// maximum number of parameters to a command
+#define MAX_ARGS 80
+// maximum tokenizable commandline length (counting NUL terminations)
+#define CMD_TOKENIZELENGTH (MAX_INPUTLINE + 80)
typedef struct cmdalias_s
{
static mempool_t *cmd_mempool;
-#define CMD_TOKENIZELENGTH 4096
static char cmd_tokenizebuffer[CMD_TOKENIZELENGTH];
static int cmd_tokenizebufferpos = 0;
=============================================================================
*/
- // LordHavoc: inreased this from 8192 to 32768
static sizebuf_t cmd_text;
-static qbyte cmd_text_buf[32768];
+static unsigned char cmd_text_buf[CMDBUFSIZE];
/*
============
return;
}
- SZ_Write (&cmd_text, text, (int)strlen (text));
+ SZ_Write (&cmd_text, (const unsigned char *)text, (int)strlen (text));
}
templen = cmd_text.cursize;
if (templen)
{
- temp = Mem_Alloc (tempmempool, templen);
+ temp = (char *)Mem_Alloc (tempmempool, templen);
memcpy (temp, cmd_text.data, templen);
SZ_Clear (&cmd_text);
}
// add the copied off data
if (temp != NULL)
{
- SZ_Write (&cmd_text, temp, templen);
+ SZ_Write (&cmd_text, (const unsigned char *)temp, templen);
Mem_Free (temp);
}
}
Cbuf_Execute
============
*/
+static void Cmd_PreprocessString( const char *intext, char *outtext, unsigned maxoutlen, cmdalias_t *alias );
void Cbuf_Execute (void)
{
int i;
char *text;
- char line[1024];
+ char line[MAX_INPUTLINE];
+ char preprocessed[MAX_INPUTLINE];
int quotes;
// LordHavoc: making sure the tokenizebuffer doesn't get filled up by repeated crashes
}
// execute the command line
- Cmd_ExecuteString (line, src_command);
+ Cmd_PreprocessString( line, preprocessed, sizeof(preprocessed), NULL );
+ Cmd_ExecuteString (preprocessed, src_command);
if (cmd_wait)
{ // skip out while text still remains in buffer, leaving it
{
int i, j, l;
// this is per command, and bounds checked (no buffer overflows)
- char build[2048];
+ char build[MAX_INPUTLINE];
if (Cmd_Argc () != 1)
{
return;
}
- f = (char *)FS_LoadFile (Cmd_Argv(1), tempmempool, false);
+ f = (char *)FS_LoadFile (Cmd_Argv(1), tempmempool, false, NULL);
if (!f)
{
Con_Printf("couldn't exec %s\n",Cmd_Argv(1));
static void Cmd_Alias_f (void)
{
cmdalias_t *a;
- char cmd[1024];
+ char cmd[MAX_INPUTLINE];
int i, c;
const char *s;
{
cmdalias_t *prev, *current;
- a = Z_Malloc (sizeof(cmdalias_t));
+ a = (cmdalias_t *)Z_Malloc (sizeof(cmdalias_t));
strlcpy (a->name, s, sizeof (a->name));
// insert it at the right alphanumeric position
for( prev = NULL, current = cmd_alias ; current && strcmp( current->name, a->name ) < 0 ; prev = current, current = current->next )
}
strlcat (cmd, "\n", sizeof (cmd));
- a->value = Z_Malloc (strlen (cmd) + 1);
+ a->value = (char *)Z_Malloc (strlen (cmd) + 1);
strcpy (a->value, cmd);
}
xcommand_t function;
} cmd_function_t;
-
-#define MAX_ARGS 80
-
static int cmd_argc;
static const char *cmd_argv[MAX_ARGS];
static const char *cmd_null_string = "";
-static const char *cmd_args = NULL;
-
+static const char *cmd_args;
cmd_source_t cmd_source;
static cmd_function_t *cmd_functions; // possible commands to execute
/*
-============
-Cmd_ExecuteAlias
+Cmd_PreprocessString
-Called for aliases and fills in the alias into the cbuffer
-============
+Preprocesses strings and replaces $*, $param#, $cvar accordingly
*/
-static void Cmd_ExecuteAlias (cmdalias_t *alias)
-{
-#define ALIAS_BUFFER 1024
- static char buffer[ ALIAS_BUFFER + 2 ];
+static void Cmd_PreprocessString( const char *intext, char *outtext, unsigned maxoutlen, cmdalias_t *alias ) {
const char *in;
- char *out;
unsigned outlen;
int inquote;
- in = alias->value;
- out = buffer;
+ // don't crash if there's no room in the outtext buffer
+ if( maxoutlen == 0 ) {
+ return;
+ }
+ maxoutlen--; // because of \0
+
+ in = intext;
outlen = 0;
inquote = 0;
- while( *in && outlen < ALIAS_BUFFER )
- {
- if( *in == '"' )
- {
- inquote ^= 1;
- }
- else if( *in == '$' && !inquote )
- {
- // $* is replaced with all formal parameters, $num is parsed as an argument (or as $num if there arent enough parameters), $bla becomes $bla and $$bla becomes $$bla
- // read over the $
+ while( *in && outlen < maxoutlen ) {
+ if( *in == '$' && !inquote ) {
+ // this is some kind of expansion, see what comes after the $
in++;
- if( *in == '*' )
- {
+ // replacements that can always be used:
+ // $$ is replaced with $, to allow escaping $
+ // $<cvarname> is replaced with the contents of the cvar
+ //
+ // the following can be used in aliases only:
+ // $* is replaced with all formal parameters (including name of the alias - this probably is not desirable)
+ // $0 is replaced with the name of this alias
+ // $<number> is replaced with an argument to this alias (or copied as-is if no such parameter exists), can be multiple digits
+ if( *in == '$' ) {
+ outtext[outlen++] = *in++;
+ } else if( *in == '*' && alias ) {
const char *linein = Cmd_Args();
// include all params
- while( *linein && outlen < ALIAS_BUFFER ) {
- *out++ = *linein++;
- outlen++;
+ if (linein) {
+ while( *linein && outlen < maxoutlen ) {
+ outtext[outlen++] = *linein++;
+ }
}
in++;
- } else {
+ } else if( '0' <= *in && *in <= '9' && alias ) {
char *nexttoken;
int argnum;
argnum = strtol( in, &nexttoken, 10 );
- if( 0 < argnum && argnum < Cmd_Argc() )
- {
+ if( 0 <= argnum && argnum < Cmd_Argc() ) {
const char *param = Cmd_Argv( argnum );
- while( *param && outlen < ALIAS_BUFFER ) {
- *out++ = *param++;
- outlen++;
+ while( *param && outlen < maxoutlen ) {
+ outtext[outlen++] = *param++;
}
in = nexttoken;
- }
- else if( argnum >= Cmd_Argc() )
- {
+ } else if( argnum >= Cmd_Argc() ) {
Con_Printf( "Warning: Not enough parameters passed to alias '%s', at least %i expected:\n %s\n", alias->name, argnum, alias->value );
- *out++ = '$';
- outlen++;
+ outtext[outlen++] = '$';
}
- // not a number
- else if( argnum == 0 )
- {
- *out++ = '$';
- outlen++;
+ } else {
+ cvar_t *cvar;
+ const char *tempin = in;
+
+ COM_ParseTokenConsole( &tempin );
+ if ((cvar = Cvar_FindVar(&com_token[0]))) {
+ const char *cvarcontent = cvar->string;
+ while( *cvarcontent && outlen < maxoutlen ) {
+ outtext[outlen++] = *cvarcontent++;
+ }
+ in = tempin;
+ } else {
+ Con_Printf( "Warning: could not find cvar %s when expanding alias %s\n %s\n", com_token, alias->name, alias->value );
+ outtext[outlen++] = '$';
}
}
} else {
- *out++ = *in++;
- outlen++;
+ if( *in == '"' ) {
+ inquote ^= 1;
+ }
+ outtext[outlen++] = *in++;
}
}
- *out++ = '\n';
- *out++ = 0;
+ outtext[outlen] = 0;
+}
+
+/*
+============
+Cmd_ExecuteAlias
+
+Called for aliases and fills in the alias into the cbuffer
+============
+*/
+static void Cmd_ExecuteAlias (cmdalias_t *alias)
+{
+ static char buffer[ MAX_INPUTLINE + 2 ];
+ Cmd_PreprocessString( alias->value, buffer, sizeof(buffer) - 2, alias );
Cbuf_AddText( buffer );
}
count++;
}
- Con_Printf("%i Command%s", count, (count > 1) ? "s" : "");
if (partial)
- Con_Printf(" beginning with \"%s\"", partial);
-
- Con_Print("\n\n");
+ Con_Printf("%i Command%s beginning with \"%s\"\n\n", count, (count > 1) ? "s" : "", partial);
+ else
+ Con_Printf("%i Command%s\n\n", count, (count > 1) ? "s" : "");
}
/*
Parses the given string into command line tokens.
============
*/
+// AK: This function should only be called from ExcuteString because the current design is a bit of an hack
static void Cmd_TokenizeString (const char *text)
{
int l;
// Windows: \r\n
if (*text == '\n' || *text == '\r')
{
- // a newline seperates commands in the buffer
+ // a newline separates commands in the buffer
if (*text == '\r' && text[1] == '\n')
text++;
text++;
return;
if (cmd_argc == 1)
- cmd_args = text;
+ cmd_args = text;
if (!COM_ParseTokenConsole(&text))
return;
- // check for $cvar
- // (perhaps use another target buffer?)
- if (com_token[0] == '$' && com_token[1])
- {
- cvar_t *cvar;
-
- cvar = Cvar_FindVar(&com_token[1]);
- if (cvar)
- {
- strcpy(com_token, cvar->string);
- }
- else if( com_token[1] == '$' )
- {
- // remove the first $
- char *pos;
-
- for( pos = com_token ; *pos ; pos++ )
- {
- *pos = *(pos + 1);
- }
- }
- }
-
if (cmd_argc < MAX_ARGS)
{
l = (int)strlen(com_token) + 1;
}
}
- cmd = Mem_Alloc(cmd_mempool, sizeof(cmd_function_t));
+ cmd = (cmd_function_t *)Mem_Alloc(cmd_mempool, sizeof(cmd_function_t));
cmd->name = cmd_name;
cmd->function = function;
cmd->next = cmd_functions;
const char **buf;
len = strlen(partial);
- buf = Mem_Alloc(tempmempool, sizeofbuf + sizeof (const char *));
+ buf = (const char **)Mem_Alloc(tempmempool, sizeofbuf + sizeof (const char *));
// Loop through the alias list and print all matches
for (cmd = cmd_functions; cmd; cmd = cmd->next)
if (!strncasecmp(partial, cmd->name, len))
const char **buf;
len = strlen(partial);
- buf = Mem_Alloc(tempmempool, sizeofbuf + sizeof (const char *));
+ buf = (const char **)Mem_Alloc(tempmempool, sizeofbuf + sizeof (const char *));
// Loop through the alias list and print all matches
for (alias = cmd_alias; alias; alias = alias->next)
if (!strncasecmp(partial, alias->name, len))
oldpos = cmd_tokenizebufferpos;
cmd_source = src;
+
Cmd_TokenizeString (text);
// execute the command line
// attention, it has been eradicated from here, its only (former) use in
// all of darkplaces.
MSG_WriteByte(&cls.message, clc_stringcmd);
- SZ_Write(&cls.message, s, (int)strlen(s) + 1);
+ SZ_Write(&cls.message, (const unsigned char *)s, (int)strlen(s) + 1);
}
/*