X-Git-Url: https://git.xonotic.org/?a=blobdiff_plain;f=qcsrc%2Fcommon%2Feffects%2Fqc%2Fcasings.qc;h=95e90a149c5e550b690e5901b574d71a4b887bd2;hb=dc5a8ddfc5a4a9371de7bbee815cc192898939be;hp=c0c7f5ac98d41bc95cb90948d4234f84c007f6dc;hpb=4f4c471a6ba861785a118487ac2ddadaead70d52;p=xonotic%2Fxonotic-data.pk3dir.git

diff --git a/qcsrc/common/effects/qc/casings.qc b/qcsrc/common/effects/qc/casings.qc
index c0c7f5ac9..95e90a149 100644
--- a/qcsrc/common/effects/qc/casings.qc
+++ b/qcsrc/common/effects/qc/casings.qc
@@ -22,10 +22,20 @@ void SpawnCasing(vector vel, float randomvel, vector ang, vector avel, float ran
 	FOREACH_CLIENT(true, {
 		if (!(CS_CVAR(it).cvar_cl_casings))
 			continue;
-		if (it == casingowner && !(CS_CVAR(it).cvar_r_drawviewmodel))
+
+		casingtype &= 0x3F; // reset any bitflags that were set for the previous client
+
+		if (it == casingowner || (IS_SPEC(it) && it.enemy == casingowner))
+		{
+			if (!(CS_CVAR(it).cvar_r_drawviewmodel))
+				continue;
+
+			casingtype |= 0x40; // client will apply autocvar_cl_gunoffset in first person
+		}
+		else if (1 & ~checkpvs(it.origin + it.view_ofs, casingowner)) // 1 or 3 means visible
 			continue;
 
-		msg_entity = it;
+		msg_entity = it; // sound_allowed checks this
 		if (!sound_allowed(MSG_ONE, it))
 			casingtype |= 0x80; // silent
 
@@ -35,7 +45,7 @@ void SpawnCasing(vector vel, float randomvel, vector ang, vector avel, float ran
 		WriteShort(MSG_ONE, compressShortVector(vel)); // actually compressed velocity
 		WriteByte(MSG_ONE, ang.x * 256 / 360);
 		WriteByte(MSG_ONE, ang.y * 256 / 360);
-		WriteByte(MSG_ONE, ang.z * 256 / 360);
+		// weapons only have pitch and yaw, so no need to send ang.z
 	});
 }
 #endif
@@ -133,30 +143,30 @@ void Casing_Damage(entity this, float thisdmg, int hittype, vector org, vector t
 
 NET_HANDLE(casings, bool isNew)
 {
-    int _state = ReadByte();
-    vector org = ReadVector();
-    vector vel = decompressShortVector(ReadShort());
-    vector ang;
-    ang_x = ReadByte() * 360 / 256;
-    ang_y = ReadByte() * 360 / 256;
-    ang_z = ReadByte() * 360 / 256;
+    Casing casing = ListNewChildRubble(CasingsNGibs, new(casing));
+
+    casing.state = ReadByte();
+    casing.origin = ReadVector();
+    casing.velocity = decompressShortVector(ReadShort());
+    casing.angles_x = ReadByte() * 360 / 256;
+    casing.angles_y = ReadByte() * 360 / 256;
+
     return = true;
 
-    Casing casing = ListNewChildRubble(CasingsNGibs, new(casing));
-    casing.silent = (_state & 0x80);
-    casing.state = (_state & 0x7F);
-    casing.origin = org;
+    casing.silent = casing.state & 0x80;
+    if (casing.state & 0x40 && !autocvar_chase_active)
+        casing.origin += autocvar_cl_gunoffset.x * v_forward
+                       - autocvar_cl_gunoffset.y * v_right
+                       + autocvar_cl_gunoffset.z * v_up;
+    casing.state &= 0x3F; // the 2 most significant bits are reserved for the silent and casingowner bitflags
+
     setorigin(casing, casing.origin);
-    casing.velocity = vel;
-    casing.angles = ang;
     casing.drawmask = MASK_NORMAL;
-
     casing.draw = Casing_Draw;
     if (isNew) IL_PUSH(g_drawables, casing);
-    casing.velocity = casing.velocity + 2 * prandomvec();
+    casing.velocity += 2 * prandomvec();
     casing.avelocity = '0 250 0' + 100 * prandomvec();
     set_movetype(casing, MOVETYPE_BOUNCE);
-    casing.bouncefactor = 0.25;
     settouch(casing, Casing_Touch);
     casing.move_time = time;
     casing.event_damage = Casing_Damage;
@@ -166,10 +176,12 @@ NET_HANDLE(casings, bool isNew)
     {
         case 1:
             setmodel(casing, MDL_CASING_SHELL);
+            casing.bouncefactor = 0.25;
             casing.cnt = time + autocvar_cl_casings_shell_time;
             break;
         default:
             setmodel(casing, MDL_CASING_BULLET);
+            casing.bouncefactor = 0.5;
             casing.cnt = time + autocvar_cl_casings_bronze_time;
             break;
     }