Fix memory corruption in loadconfig while in game/menu.

[xonotic/darkplaces.git] / gl_rsurf.c

diff --git a/gl_rsurf.c b/gl_rsurf.c
index 98c364934bc1ab87be37335f8ff5401cfbd4e002..d589cfcb1b726f3f83304063c83b4267411b8628 100644 (file)
--- a/gl_rsurf.c
+++ b/gl_rsurf.c
@@ -524,6 +524,8 @@ void R_View_WorldVisibility(qboolean forcenovis)
                        int leafstackpos;
                        mportal_t *p;
                        mleaf_t *leafstack[8192];
+                       vec3_t cullmins, cullmaxs;
+                       float cullbias = r_nearclip.value * 2.0f; // the nearclip plane can easily end up culling portals in certain perfectly-aligned views, causing view blackouts
                        // simple-frustum portal method:
                        // follows portals leading outward from viewleaf, does not venture
                        // offscreen or into leafs that are not visible, faster than
@@ -548,20 +550,27 @@ void R_View_WorldVisibility(qboolean forcenovis)
                                                r_refdef.viewcache.world_surfacevisible[*mark] = true;
                                // follow portals into other leafs
                                // the checks are:
-                               // if viewer is behind portal (portal faces outward into the scene)
-                               // and the portal polygon's bounding box is on the screen
-                               // and the leaf has not been visited yet
+                               // the leaf has not been visited yet
                                // and the leaf is visible in the pvs
-                               // (the first two checks won't cause as many cache misses as the leaf checks)
+                               // the portal polygon's bounding box is on the screen
                                for (p = leaf->portals;p;p = p->next)
                                {
                                        r_refdef.stats[r_stat_world_portals]++;
-                                       if (DotProduct(r_refdef.view.origin, p->plane.normal) < (p->plane.dist + 1)
-                                        && !r_refdef.viewcache.world_leafvisible[p->past - model->brush.data_leafs]
-                                        && CHECKPVSBIT(r_refdef.viewcache.world_pvsbits, p->past->clusterindex)
-                                        && !R_CullBox(p->mins, p->maxs)
-                                        && leafstackpos < (int)(sizeof(leafstack) / sizeof(leafstack[0])))
-                                               leafstack[leafstackpos++] = p->past;
+                                       if (r_refdef.viewcache.world_leafvisible[p->past - model->brush.data_leafs])
+                                               continue;
+                                       if (!CHECKPVSBIT(r_refdef.viewcache.world_pvsbits, p->past->clusterindex))
+                                               continue;
+                                       cullmins[0] = p->mins[0] - cullbias;
+                                       cullmins[1] = p->mins[1] - cullbias;
+                                       cullmins[2] = p->mins[2] - cullbias;
+                                       cullmaxs[0] = p->maxs[0] + cullbias;
+                                       cullmaxs[1] = p->maxs[1] + cullbias;
+                                       cullmaxs[2] = p->maxs[2] + cullbias;
+                                       if (R_CullBox(cullmins, cullmaxs))
+                                               continue;
+                                       if (leafstackpos >= (int)(sizeof(leafstack) / sizeof(leafstack[0])))
+                                               break;
+                                       leafstack[leafstackpos++] = p->past;
                                }
                        }
                }
@@ -637,7 +646,7 @@ void R_Q1BSP_Draw(entity_render_t *ent)
 void R_Q1BSP_DrawDepth(entity_render_t *ent)
 {
        dp_model_t *model = ent->model;
-       if (model == NULL)
+       if (model == NULL || model->surfmesh.isanimated)
                return;
        GL_ColorMask(0,0,0,0);
        GL_Color(1,1,1,1);
@@ -766,13 +775,13 @@ static void R_Q1BSP_RecursiveGetLightInfo_BSP(r_q1bsp_getlightinfo_t *info, qboo
                                        // recurse front side first because the svbsp building prefers it
                                        if (info->relativelightorigin[plane->type] >= plane->dist)
                                        {
-                                               if (nodestackpos < GETLIGHTINFO_MAXNODESTACK)
+                                               if (nodestackpos < GETLIGHTINFO_MAXNODESTACK-1)
                                                        nodestack[nodestackpos++] = node->children[0];
                                                nodestack[nodestackpos++] = node->children[1];
                                        }
                                        else
                                        {
-                                               if (nodestackpos < GETLIGHTINFO_MAXNODESTACK)
+                                               if (nodestackpos < GETLIGHTINFO_MAXNODESTACK-1)
                                                        nodestack[nodestackpos++] = node->children[1];
                                                nodestack[nodestackpos++] = node->children[0];
                                        }
@@ -796,13 +805,13 @@ static void R_Q1BSP_RecursiveGetLightInfo_BSP(r_q1bsp_getlightinfo_t *info, qboo
                                        // recurse front side first because the svbsp building prefers it
                                        if (PlaneDist(info->relativelightorigin, plane) >= 0)
                                        {
-                                               if (nodestackpos < GETLIGHTINFO_MAXNODESTACK)
+                                               if (nodestackpos < GETLIGHTINFO_MAXNODESTACK-1)
                                                        nodestack[nodestackpos++] = node->children[0];
                                                nodestack[nodestackpos++] = node->children[1];
                                        }
                                        else
                                        {
-                                               if (nodestackpos < GETLIGHTINFO_MAXNODESTACK)
+                                               if (nodestackpos < GETLIGHTINFO_MAXNODESTACK-1)
                                                        nodestack[nodestackpos++] = node->children[1];
                                                nodestack[nodestackpos++] = node->children[0];
                                        }
@@ -1075,7 +1084,7 @@ static void R_Q1BSP_RecursiveGetLightInfo_BIH(r_q1bsp_getlightinfo_t *info, cons
 #endif
                        if (info->lightmins[axis] <= node->backmax)
                        {
-                               if (info->lightmaxs[axis] >= node->frontmin && nodestackpos < GETLIGHTINFO_MAXNODESTACK)
+                               if (info->lightmaxs[axis] >= node->frontmin && nodestackpos < GETLIGHTINFO_MAXNODESTACK-1)
                                        nodestack[nodestackpos++] = node->front;
                                nodestack[nodestackpos++] = node->back;
                                continue;
@@ -1423,10 +1432,7 @@ void R_Q1BSP_DrawShadowMap(int side, entity_render_t *ent, const vec3_t relative
                --modelsurfacelistindex;
                GL_CullFace(rsurface.texture->currentmaterialflags & MATERIALFLAG_NOCULLFACE ? GL_NONE : r_refdef.view.cullface_back);
                RSurf_PrepareVerticesForBatch(BATCHNEED_ARRAY_VERTEX | BATCHNEED_ALLOWMULTIDRAW, batchnumsurfaces, batchsurfacelist);
-               if (rsurface.batchvertex3fbuffer)
-                       R_Mesh_PrepareVertices_Vertex3f(rsurface.batchnumvertices, rsurface.batchvertex3f, rsurface.batchvertex3fbuffer);
-               else
-                       R_Mesh_PrepareVertices_Vertex3f(rsurface.batchnumvertices, rsurface.batchvertex3f, rsurface.batchvertex3f_vertexbuffer);
+               R_Mesh_PrepareVertices_Vertex3f(rsurface.batchnumvertices, rsurface.batchvertex3f, rsurface.batchvertex3f_vertexbuffer, rsurface.batchvertex3f_bufferoffset);
                RSurf_DrawBatch();
        }
        R_FrameData_ReturnToMark();