int => ['V', 4, signed 32],
ushort => ['v', 2, id],
short => ['v', 2, signed 16],
- opcode => ['v', 2, sub { OPCODE_E->[$_[0]] or die "Invalid opcode: $_[0]"; }],
+ opcode => ['v', 2, sub { OPCODE_E->[$_[0]] or do { warn "Invalid opcode: $_[0]"; "INVALID#$_[0]"; }; }],
float => ['f', 4, id],
uchar8 => ['a8', 8, sub { [unpack 'C8', $_[0]] }],
global => ['i', 4, sub { { int => $_[0], float => unpack "f", pack "L", $_[0] }; }],
no warnings 'recursion';
my ($ip, $state) = @_;
+ my $ret = 0;
for(;;)
{
- return
+ return $ret
if $state_checker->($ip, $state);
my $s = $statements->[$ip];
my $c = checkop $s->{op};
- if($instruction_handler->($ip, $state, $s, $c))
+ if(($ret = $instruction_handler->($ip, $state, $s, $c)))
{
# abort execution
last;
{
last;
}
+ elsif($c->{iscall})
+ {
+ my $func = $s->{a};
+ my $funcid = $progs->{globals}[$func]{v}{int};
+ last
+ if $progs->{error_func}{$funcid};
+ $ip += 1;
+ }
elsif($c->{isjump})
{
if($c->{isconditional})
{
if(rand 2)
{
- $nfa->($ip+$s->{$c->{isjump}}, $copy_handler->($state));
+ if(($ret = $nfa->($ip+$s->{$c->{isjump}}, $copy_handler->($state))) < 0)
+ {
+ last;
+ }
$ip += 1;
}
else
$ip += 1;
}
}
+
+ return $ret;
};
$nfa->($ip, $copy_handler->($state));
my ($progs, $g) = @_;
if($g->{int} == 0)
{
- return undef;
+ return 0;
}
- elsif($g->{int} > 0 && $g->{int} < 16777216)
+ elsif($g->{int} > 0 && $g->{int} < 8388608)
{
if($g->{int} < length $progs->{strings} && $g->{int} > 0)
{
my $getname = sub
{
my ($ofs) = @_;
- $ofs &= 0xFFFF;
return $override_locals{$ofs}
if exists $override_locals{$ofs};
my $def = $progs->{globaldef_byoffset}->($ofs);
}
};
- my %statements = ();
- my %come_from = ();
- run_nfa $progs, $func->{first_statement}, "", id, nfa_default_state_checker,
- sub
- {
- my ($ip, $state, $s, $c) = @_;
- ++$statements{$ip};
-
- if(my $j = $c->{isjump})
- {
- my $t = $ip + $s->{$j};
- $come_from{$t}{$ip} = $c->{isconditional};
- }
-
- return 0;
- };
+ my $statements = $func->{statements};
+ my $come_from = $func->{come_from};
my $ipprev = undef;
- for my $ip(sort { $a <=> $b } keys %statements)
+ for my $ip(sort { $a <=> $b } keys %$statements)
{
if($ip == $func->{first_statement})
{
printf OPERAND_FORMAT, $ip - $ipprev - 1;
print INSTRUCTION_SEPARATOR;
}
- if(my $cf = $come_from{$ip})
+ if(my $cf = $come_from->{$ip})
{
printf INSTRUCTION_FORMAT, $ip, '', '.XREF';
my $cnt = 0;
{
my ($progs, $func) = @_;
-# TODO
-# 21:04:25 divVerent | just wondering how I can best detect "temp value is never used"
-# 21:04:33 divVerent | I know which vars are temps already
-# 21:04:59 divVerent | basically, looks like for each write, I will not just have to track that the new value is valid
-# 21:05:01 divVerent | but also its source
-# 21:05:12 divVerent | on each read, I'll remember that this source statement's value has been used
-# 21:05:21 divVerent | and will compare the list of sources in a step after "execution"
-# 21:05:27 divVerent | to the list of total write statements to the temp
return
if $func->{first_statement} < 0; # builtin
for(keys %{$progs->{temps}})
{
- $watchme{$_} = WATCHME_T | WATCHME_X
- if not exists $watchme{$_};
+ next
+ if exists $watchme{$_};
+ if($progs->{temps}{$_})
+ {
+ # shared temp
+ $watchme{$_} = WATCHME_T | WATCHME_X
+ }
+ else
+ {
+ # unique temp
+ $watchme{$_} = WATCHME_X
+ }
}
+ $watchme{$_} |= WATCHME_R
+ for keys %{$func->{globals_read}};
+ $watchme{$_} |= WATCHME_W
+ for keys %{$func->{globals_written}};
+
my %write_places = ();
- run_nfa $progs, $func->{first_statement}, "", id, nfa_default_state_checker,
- sub
+ for my $ofs(keys %{$func->{globals_written}})
+ {
+ next
+ unless exists $watchme{$ofs} and $watchme{$ofs} & WATCHME_X;
+ for my $ip(keys %{$func->{globals_written}{$ofs}})
{
- my ($ip, $state, $s, $c) = @_;
- for(qw(a b c))
+ for my $op(keys %{$func->{globals_written}{$ofs}{$ip}})
{
- my $type = $c->{$_};
- next
- unless defined $type;
-
- my $ofs = $s->{$_};
- if($type eq 'inglobal' || $type eq 'inglobalfunc')
- {
- $watchme{$ofs} |= WATCHME_R;
- }
- elsif($type eq 'inglobalvec')
- {
- $watchme{$ofs} |= WATCHME_R;
- $watchme{$ofs+1} |= WATCHME_R;
- $watchme{$ofs+2} |= WATCHME_R;
- }
- elsif($type eq 'outglobal')
- {
- $watchme{$ofs} |= WATCHME_W;
- $write_places{$ip}{$_} = $_
- if $watchme{$ofs} & WATCHME_X;
- }
- elsif($type eq 'outglobalvec')
- {
- $watchme{$ofs} |= WATCHME_W;
- $watchme{$ofs+1} |= WATCHME_W;
- $watchme{$ofs+2} |= WATCHME_W;
- $write_places{$ip}{$_} = 1
- if ($watchme{$ofs} | $watchme{$ofs+1} | $watchme{$ofs+2}) & WATCHME_X;
- }
+ push @{$write_places{$ip}{$op}}, $ofs;
}
-
- return 0;
- };
+ }
+ }
for(keys %watchme)
{
{
# if $state is stronger or equal to $s, return 1
- # FIXME this is wrong now
- # when merging states, we also must somehow merge initialization sources
- # to become the union, EVEN for already analyzes future instructions!
- # maybe can do this by abusing references
- # and thereby adjusting the value after the fact
-
for(keys %$state)
{
- if($state->{$_}{valid}[0] < $s->{$_}[0])
+ if($state->{$_}{valid}[0] < $s->{$_})
{
# The current state is LESS valid than the previously run one. We NEED to run this.
# The saved state can safely become the intersection [citation needed].
for(keys %$state)
{
- $s->{$_} = $state->{$_}{valid}
- if $state->{$_}{valid}[0] < $s->{$_}[0];
+ $s->{$_} = $state->{$_}{valid}[0]
+ if $state->{$_}{valid}[0] < $s->{$_};
}
return 0;
}
else
{
# Never seen this IP yet.
- $ip_seen{$ip} = { map { ($_ => $state->{$_}{valid}); } keys %$state };
+ $ip_seen{$ip} = { map { ($_ => $state->{$_}{valid}[0]); } keys %$state };
return 0;
}
},
}
}
}
- else # builtin
- {
- my $def = $progs->{globaldef_byoffset}->($func);
- return 1
- if $def->{debugname} eq 'error';
- }
}
return 0;
};
-# for my $ip(keys %write_places)
-# {
-# for(keys %{$write_places{$ip}})
-# {
-# print "; Value is never used in $func->{debugname} at $ip.$_\n";
-# ++$warned{$ip}{$_};
-# }
-# }
+ for my $ip(keys %write_places)
+ {
+ for my $operand(keys %{$write_places{$ip}})
+ {
+ # TODO verify it
+ my %left = map { $_ => 1 } @{$write_places{$ip}{$operand}};
+ my $isread = 0;
+
+ my %writeplace_seen = ();
+ run_nfa $progs, $ip+1, \%left,
+ sub
+ {
+ return { %{$_[0]} };
+ },
+ sub
+ {
+ my ($ip, $state) = @_;
+ return $writeplace_seen{"$ip " . join " ", sort keys %$state}++;
+ },
+ sub
+ {
+ my ($ip, $state, $s, $c) = @_;
+ for(qw(a b c))
+ {
+ my $type = $c->{$_};
+ next
+ unless defined $type;
+
+ my $ofs = $s->{$_};
+ if($type eq 'inglobal' || $type eq 'inglobalfunc')
+ {
+ if($state->{$ofs})
+ {
+ $isread = 1;
+ return -1; # exit TOTALLY
+ }
+ }
+ elsif($type eq 'inglobalvec')
+ {
+ if($state->{$ofs} || $state->{$ofs+1} || $state->{$ofs+2})
+ {
+ $isread = 1;
+ return -1; # exit TOTALLY
+ }
+ }
+ elsif($type eq 'outglobal')
+ {
+ delete $state->{$ofs};
+ return 1
+ if !%$state;
+ }
+ elsif($type eq 'outglobalvec')
+ {
+ delete $state->{$ofs};
+ delete $state->{$ofs+1};
+ delete $state->{$ofs+2};
+ return 1
+ if !%$state;
+ }
+ }
+ return 0;
+ };
+
+ if(!$isread)
+ {
+ print "; Value is never used in $func->{debugname} at $ip.$operand\n";
+ ++$warned{$ip}{$operand};
+ }
+ }
+ }
disassemble_function($progs, $func, \%warned)
if keys %warned;
return { ofs => $ofs, s_name => undef, debugname => "<undefined>\@$ofs", type => undef };
}
-sub parse_progs($)
+sub detect_constants($)
{
- my ($fh) = @_;
-
- my %p = ();
-
- print STDERR "Parsing header...\n";
- $p{header} = parse_section $fh, DPROGRAMS_T, 0, undef, 1;
-
- print STDERR "Parsing strings...\n";
- $p{strings} = get_section $fh, $p{header}{ofs_strings}, $p{header}{numstrings};
- $p{getstring} = sub
+ my ($progs) = @_;
+ use constant GLOBALFLAG_R => 1; # read
+ use constant GLOBALFLAG_W => 2; # written
+ use constant GLOBALFLAG_S => 4; # saved
+ use constant GLOBALFLAG_I => 8; # initialized
+ use constant GLOBALFLAG_N => 16; # named
+ use constant GLOBALFLAG_Q => 32; # unique to function
+ use constant GLOBALFLAG_U => 64; # unused
+ my @globalflags = (GLOBALFLAG_Q | GLOBALFLAG_U) x @{$progs->{globals}};
+
+ for(@{$progs->{functions}})
{
- my ($startpos) = @_;
- my $endpos = index $p{strings}, "\0", $startpos;
- return substr $p{strings}, $startpos, $endpos - $startpos;
- };
-
- print STDERR "Parsing statements...\n";
- $p{statements} = [parse_section $fh, DSTATEMENT_T, $p{header}{ofs_statements}, undef, $p{header}{numstatements}];
-
- print STDERR "Parsing globaldefs...\n";
- $p{globaldefs} = [parse_section $fh, DDEF_T, $p{header}{ofs_globaldefs}, undef, $p{header}{numglobaldefs}];
-
- print STDERR "Parsing fielddefs...\n";
- $p{fielddefs} = [parse_section $fh, DDEF_T, $p{header}{ofs_fielddefs}, undef, $p{header}{numfielddefs}];
-
- print STDERR "Parsing globals...\n";
- $p{globals} = [parse_section $fh, DGLOBAL_T, $p{header}{ofs_globals}, undef, $p{header}{numglobals}];
-
- print STDERR "Parsing functions...\n";
- $p{functions} = [parse_section $fh, DFUNCTION_T, $p{header}{ofs_functions}, undef, $p{header}{numfunctions}];
+ for(keys %{$_->{globals_used}})
+ {
+ if($globalflags[$_] & GLOBALFLAG_U)
+ {
+ $globalflags[$_] &= ~GLOBALFLAG_U;
+ }
+ elsif($globalflags[$_] & GLOBALFLAG_Q)
+ {
+ $globalflags[$_] &= ~GLOBALFLAG_Q;
+ }
+ }
+ $globalflags[$_] |= GLOBALFLAG_R
+ for keys %{$_->{globals_read}};
+ $globalflags[$_] |= GLOBALFLAG_W
+ for keys %{$_->{globals_written}};
+ }
- print STDERR "Detecting temps...\n";
my %offsets_saved = ();
- for(@{$p{globaldefs}})
+ for(@{$progs->{globaldefs}})
{
my $type = $_->{type};
- my $name = $p{getstring}->($_->{s_name});
- next
- unless $type->{save} or $name ne "";
- for my $i(0..(typesize($_->{type}{type})-1))
+ my $name = $progs->{getstring}->($_->{s_name});
+ if($type->{save})
+ {
+ for my $i(0..(typesize($_->{type}{type})-1))
+ {
+ $globalflags[$_->{ofs}] |= GLOBALFLAG_S;
+ }
+ }
+ if($name ne "")
{
- ++$offsets_saved{$_->{ofs}+$i};
+ for my $i(0..(typesize($_->{type}{type})-1))
+ {
+ $globalflags[$_->{ofs}] |= GLOBALFLAG_N;
+ }
}
}
my %offsets_initialized = ();
- for(0..(@{$p{globals}}-1))
+ for(0..(@{$progs->{globals}}-1))
{
- if($p{globals}[$_]{v}{int})
+ if($progs->{globals}[$_]{v}{int})
{
- ++$offsets_initialized{$_};
+ $globalflags[$_] |= GLOBALFLAG_I;
}
}
+
+ my @globaltypes = (undef) x @{$progs->{globals}};
+
my %istemp = ();
- my %isconst = ();
- for(0..(@{$p{globals}}-1))
+ for(0..(@{$progs->{globals}}-1))
{
next
if $_ < @{(DEFAULTGLOBALS)};
- ++$isconst{$_}
- if !$offsets_saved{$_} and $offsets_initialized{$_};
- ++$istemp{$_}
- if !$offsets_saved{$_} and !$offsets_initialized{$_};
+ if(($globalflags[$_] & (GLOBALFLAG_R | GLOBALFLAG_W)) == 0)
+ {
+ $globaltypes[$_] = "unused";
+ }
+ elsif(($globalflags[$_] & (GLOBALFLAG_R | GLOBALFLAG_W)) == GLOBALFLAG_R)
+ {
+ # so it is ro
+ if(($globalflags[$_] & GLOBALFLAG_N) == GLOBALFLAG_N)
+ {
+ $globaltypes[$_] = "read_only";
+ }
+ elsif(($globalflags[$_] & GLOBALFLAG_S) == 0)
+ {
+ $globaltypes[$_] = "const";
+ }
+ else
+ {
+ $globaltypes[$_] = "read_only";
+ }
+ }
+ elsif(($globalflags[$_] & (GLOBALFLAG_R | GLOBALFLAG_W)) == GLOBALFLAG_W)
+ {
+ $globaltypes[$_] = "write_only";
+ }
+ else
+ {
+ # now we know it is rw
+ if(($globalflags[$_] & GLOBALFLAG_N) == GLOBALFLAG_N)
+ {
+ $globaltypes[$_] = "global";
+ }
+ elsif(($globalflags[$_] & (GLOBALFLAG_S | GLOBALFLAG_I | GLOBALFLAG_Q)) == GLOBALFLAG_Q)
+ {
+ $globaltypes[$_] = "uniquetemp";
+ $istemp{$_} = 0;
+ }
+ elsif(($globalflags[$_] & (GLOBALFLAG_S | GLOBALFLAG_I | GLOBALFLAG_Q)) == 0)
+ {
+ $globaltypes[$_] = "temp";
+ $istemp{$_} = 1;
+ }
+ elsif(($globalflags[$_] & (GLOBALFLAG_S | GLOBALFLAG_I)) == GLOBALFLAG_I)
+ {
+ $globaltypes[$_] = "not_saved";
+ }
+ else
+ {
+ $globaltypes[$_] = "global";
+ }
+ }
}
- $p{temps} = \%istemp;
- $p{consts} = \%isconst;
-
- print STDERR "Naming...\n";
+ $progs->{temps} = \%istemp;
# globaldefs
- my @globaldefs = ();
- for(@{$p{globaldefs}})
+ my @globaldefs = (undef) x @{$progs->{globaldefs}};
+ for(@{$progs->{globaldefs}})
{
- my $s = $p{getstring}->($_->{s_name});
- $_->{debugname} //= "_$s"
+ my $s = $progs->{getstring}->($_->{s_name});
+ $_->{debugname} //= "\$" . "$s"
if length $s;
}
- for(@{$p{globaldefs}})
+ for(@{$progs->{globaldefs}})
{
$globaldefs[$_->{ofs}] //= $_
if defined $_->{debugname};
}
- for(@{$p{globaldefs}})
+ for(@{$progs->{globaldefs}})
{
$globaldefs[$_->{ofs}] //= $_;
}
- for(0..(@{$p{globals}}-1))
+ for(0..(@{$progs->{globals}}-1))
{
$globaldefs[$_] //= {
ofs => $_,
debugname => undef
};
}
- my %globaldefs = ();
+ for(0..(@{(DEFAULTGLOBALS)}-1))
+ {
+ $globaldefs[$_] = { ofs => $_, s_name => undef, debugname => DEFAULTGLOBALS->[$_], type => undef };
+ $globaltypes[$_] = 'defglobal';
+ }
+ my %globaldefs_namecount = ();
for(@globaldefs)
{
- if(!defined $_->{debugname})
+ $_->{globaltype} = $globaltypes[$_->{ofs}];
+ if(defined $_->{debugname})
{
- if($istemp{$_->{ofs}})
- {
- $_->{debugname} = "temp_$_->{ofs}";
- }
- elsif($isconst{$_->{ofs}})
- {
- $_->{debugname} = "(" . get_constant(\%p, $p{globals}[$_->{ofs}]{v}) . ")";
- }
- else
- {
- $_->{debugname} = "global_$_->{ofs}";
- }
+ # already has debugname
}
- ++$globaldefs{$_->{debugname}};
+ elsif($_->{globaltype} eq 'const')
+ {
+ $_->{debugname} = get_constant($progs, $progs->{globals}[$_->{ofs}]{v});
+ }
+ else
+ {
+ $_->{debugname} = "$_->{globaltype}_$_->{ofs}";
+ }
+ ++$globaldefs_namecount{$_->{debugname}};
}
for(@globaldefs)
{
next
- if $globaldefs{$_->{debugname}} <= 1;
- print "Not unique: $_->{debugname} at $_->{ofs}\n";
+ if $globaldefs_namecount{$_->{debugname}} <= 1;
+ #print "Not unique: $_->{debugname} at $_->{ofs}\n";
$_->{debugname} .= "\@$_->{ofs}";
}
- $p{globaldef_byoffset} = sub
+ $progs->{globaldef_byoffset} = sub
{
my ($ofs) = @_;
- $ofs &= 0xFFFF;
- if($ofs >= 0 && $ofs < @{(DEFAULTGLOBALS)})
- {
- return { ofs => $ofs, s_name => undef, debugname => DEFAULTGLOBALS->[$ofs], type => undef };
- }
my $def = $globaldefs[$ofs];
return $def;
};
+}
+
+sub parse_progs($)
+{
+ my ($fh) = @_;
+
+ my %p = ();
+
+ print STDERR "Parsing header...\n";
+ $p{header} = parse_section $fh, DPROGRAMS_T, 0, undef, 1;
+
+ print STDERR "Parsing strings...\n";
+ $p{strings} = get_section $fh, $p{header}{ofs_strings}, $p{header}{numstrings};
+ $p{getstring} = sub
+ {
+ my ($startpos) = @_;
+ my $endpos = index $p{strings}, "\0", $startpos;
+ return substr $p{strings}, $startpos, $endpos - $startpos;
+ };
+
+ print STDERR "Parsing statements...\n";
+ $p{statements} = [parse_section $fh, DSTATEMENT_T, $p{header}{ofs_statements}, undef, $p{header}{numstatements}];
+
+ print STDERR "Fixing statements...\n";
+ for my $s(@{$p{statements}})
+ {
+ my $c = checkop $s->{op};
- # functions
- my %functions = ();
+ for(qw(a b c))
+ {
+ my $type = $c->{$_};
+ next
+ unless defined $type;
+
+ if($type eq 'inglobal' || $type eq 'inglobalfunc')
+ {
+ $s->{$_} &= 0xFFFF;
+ }
+ elsif($type eq 'inglobalvec')
+ {
+ $s->{$_} &= 0xFFFF;
+ }
+ elsif($type eq 'outglobal')
+ {
+ $s->{$_} &= 0xFFFF;
+ }
+ elsif($type eq 'outglobalvec')
+ {
+ $s->{$_} &= 0xFFFF;
+ }
+ }
+
+ }
+
+ print STDERR "Parsing globaldefs...\n";
+ $p{globaldefs} = [parse_section $fh, DDEF_T, $p{header}{ofs_globaldefs}, undef, $p{header}{numglobaldefs}];
+
+ print STDERR "Parsing fielddefs...\n";
+ $p{fielddefs} = [parse_section $fh, DDEF_T, $p{header}{ofs_fielddefs}, undef, $p{header}{numfielddefs}];
+
+ print STDERR "Parsing globals...\n";
+ $p{globals} = [parse_section $fh, DGLOBAL_T, $p{header}{ofs_globals}, undef, $p{header}{numglobals}];
+
+ print STDERR "Parsing functions...\n";
+ $p{functions} = [parse_section $fh, DFUNCTION_T, $p{header}{ofs_functions}, undef, $p{header}{numfunctions}];
+
+ print STDERR "Looking for error()...\n";
+ $p{error_func} = {};
+ for(@{$p{globaldefs}})
+ {
+ next
+ if $p{getstring}($_->{s_name}) ne 'error';
+ my $v = $p{globals}[$_->{ofs}]{v}{int};
+ next
+ if $v <= 0 || $v >= @{$p{functions}};
+ my $first = $p{functions}[$v]{first_statement};
+ next
+ if $first >= 0;
+ print STDERR "Detected error() at offset $_->{ofs} (builtin #@{[-$first]})\n";
+ $p{error_func}{$_->{ofs}} = 1;
+ }
+
+ print STDERR "Scanning functions...\n";
for(@{$p{functions}})
{
my $file = $p{getstring}->($_->{s_file});
$name = "$file:$name"
if length $file;
$_->{debugname} = $name;
- $functions{$_->{first_statement}} = $_;
+
+ next
+ if $_->{first_statement} < 0;
+
+ my %statements = ();
+ my %come_from = ();
+ my %go_to = ();
+ my %globals_read = ();
+ my %globals_written = ();
+ my %globals_used = ();
+
+ run_nfa \%p, $_->{first_statement}, "", id, nfa_default_state_checker,
+ sub
+ {
+ my ($ip, $state, $s, $c) = @_;
+ ++$statements{$ip};
+
+ if(my $j = $c->{isjump})
+ {
+ my $t = $ip + $s->{$j};
+ $come_from{$t}{$ip} = $c->{isconditional};
+ $go_to{$ip}{$t} = $c->{isconditional};
+ }
+
+ for my $o(qw(a b c))
+ {
+ my $type = $c->{$o}
+ or next;
+ my $ofs = $s->{$o};
+
+ my $read = sub
+ {
+ my ($ofs) = @_;
+ $globals_read{$ofs}{$ip}{$o} = 1;
+ $globals_used{$ofs} = 1;
+ };
+ my $write = sub
+ {
+ my ($ofs) = @_;
+ $globals_written{$ofs}{$ip}{$o} = 1;
+ $globals_used{$ofs} = 1;
+ };
+
+ if($type eq 'inglobal' || $type eq 'inglobalfunc')
+ {
+ $read->($ofs);
+ }
+ elsif($type eq 'inglobalvec')
+ {
+ $read->($ofs);
+ $read->($ofs+1);
+ $read->($ofs+2);
+ }
+ elsif($type eq 'outglobal')
+ {
+ $write->($ofs);
+ }
+ elsif($type eq 'outglobalvec')
+ {
+ $write->($ofs);
+ $write->($ofs+1);
+ $write->($ofs+2);
+ }
+ }
+
+ return 0;
+ };
+
+ $_->{statements} = \%statements;
+ $_->{come_from} = \%come_from;
+ $_->{go_to} = \%go_to;
+ $_->{globals_read} = \%globals_read;
+ $_->{globals_written} = \%globals_written;
+ $_->{globals_used} = \%globals_used;
+
+ # using this info, we could now identify basic blocks
}
- $p{function_byoffset} = sub
- {
- my ($ofs) = @_;
- return $functions{$ofs};
- };
+
+ print STDERR "Detecting constants and temps, and naming...\n";
+ detect_constants \%p;
# what do we want to do?
my $checkfunc = \&find_uninitialized_locals;