]> git.xonotic.org Git - xonotic/xonotic-data.pk3dir.git/commitdiff
Add a note about reusing bitflags in csqcmodel_settings.qh
authorMario <mario.mario@y7mail.com>
Thu, 6 Aug 2020 12:48:15 +0000 (22:48 +1000)
committerMario <mario.mario@y7mail.com>
Thu, 6 Aug 2020 12:48:15 +0000 (22:48 +1000)
qcsrc/common/csqcmodel_settings.qh

index 503cc1f22df278ac676f075a10f84287eac5ef03..ac427e877a49bcee61aec2bf794ce266c7f2506c 100644 (file)
        CSQCMODEL_PROPERTY(BIT(12), float, ReadCoord, WriteCoord, scale) \
        CSQCMODEL_PROPERTY(BIT(13), int, ReadInt24_t, WriteInt24_t, dphitcontentsmask) \
        CSQCMODEL_PROPERTY(BIT(14), TAG_VIEWLOC_TYPE, ReadShort, WriteEntity, TAG_VIEWLOC_NAME) \
+       /* bit 15 should NOT be reused, it is large enough sending the model's hitbox vectors! */ \
        CSQCMODEL_PROPERTY(BIT(16), int, ReadByte, WriteByte, multijump_count) \
        CSQCMODEL_PROPERTY(BIT(16), int, ReadByte, WriteByte, move_movetype) \
        CSQCMODEL_IF(isplayer) \
                CSQCMODEL_PROPERTY(BIT(17), GROUNDENTITY_TYPE, ReadShort, WriteEntity, GROUNDENTITY_NAME) \
        CSQCMODEL_ENDIF \
        CSQCMODEL_PROPERTY(BIT(17), int, ReadByte, WriteByte, clipgroup)
+// NOTE: bits above 15 are defined in lib/csqcmodel/common.qh, avoid reusing them if possible
 // TODO get rid of colormod/glowmod here; also get rid of some useless properties on non-players that only exist for CopyBody
 
 // add hook function calls here