X-Git-Url: http://git.xonotic.org/?a=blobdiff_plain;f=zone.c;h=941f93277ccb08d3def511e43a0d799c87c23b55;hb=cafb444b9e7458bc652c7ad9036a19f3cd273b44;hp=f5fdf73c224463d742da7e2067b8a15dd7d465a3;hpb=ce3be9028e11deb62fc4998791a02ed6b1f92895;p=xonotic%2Fdarkplaces.git

diff --git a/zone.c b/zone.c
index f5fdf73c..941f9327 100644
--- a/zone.c
+++ b/zone.c
@@ -23,7 +23,7 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 
 mempool_t *poolchain = NULL;
 
-void *_Mem_Alloc(mempool_t *pool, int size, char *filename, int fileline)
+void *_Mem_Alloc(mempool_t *pool, int size, const char *filename, int fileline)
 {
 #if MEMCLUMPING
 	int i, j, k, needed, endbit, largest;
@@ -110,24 +110,26 @@ choseclump:
 	// we have to use only a single byte for this sentinel, because it may not be aligned, and some platforms can't use unaligned accesses
 	*((qbyte *) mem + sizeof(memheader_t) + mem->size) = MEMHEADER_SENTINEL2;
 	// append to head of list
-	mem->chain = pool->chain;
+	mem->next = pool->chain;
+	mem->prev = NULL;
 	pool->chain = mem;
+	if (mem->next)
+		mem->next->prev = mem;
 	memset((void *)((qbyte *) mem + sizeof(memheader_t)), 0, mem->size);
 	return (void *)((qbyte *) mem + sizeof(memheader_t));
 }
 
-void _Mem_Free(void *data, char *filename, int fileline)
+void _Mem_Free(void *data, const char *filename, int fileline)
 {
 #if MEMCLUMPING
 	int i, firstblock, endblock;
 	memclump_t *clump, **clumpchainpointer;
 #endif
-	memheader_t *mem, **memchainpointer;
+	memheader_t *mem;
 	mempool_t *pool;
 	if (data == NULL)
 		Sys_Error("Mem_Free: data == NULL (called at %s:%i)", filename, fileline);
 
-
 	mem = (memheader_t *)((qbyte *) data - sizeof(memheader_t));
 	if (mem->sentinel1 != MEMHEADER_SENTINEL1)
 		Sys_Error("Mem_Free: trashed header sentinel 1 (alloc at %s:%i, free at %s:%i)", mem->filename, mem->fileline, filename, fileline);
@@ -135,72 +137,77 @@ void _Mem_Free(void *data, char *filename, int fileline)
 		Sys_Error("Mem_Free: trashed header sentinel 2 (alloc at %s:%i, free at %s:%i)", mem->filename, mem->fileline, filename, fileline);
 	pool = mem->pool;
 	Con_DPrintf("Mem_Free: pool %s, alloc %s:%i, free %s:%i, size %i bytes\n", pool->name, mem->filename, mem->fileline, filename, fileline, mem->size);
-	for (memchainpointer = &pool->chain;*memchainpointer;memchainpointer = &(*memchainpointer)->chain)
+	// unlink memheader from doubly linked list
+	if ((mem->prev ? mem->prev->next != mem : pool->chain != mem) || (mem->next && mem->next->prev != mem))
+		Sys_Error("Mem_Free: not allocated or double freed (free at %s:%i)", filename, fileline);
+	if (mem->prev)
+		mem->prev->next = mem->next;
+	else
+		pool->chain = mem->next;
+	if (mem->next)
+		mem->next->prev = mem->prev;
+	// memheader has been unlinked, do the actual free now
+	pool->totalsize -= mem->size;
+#if MEMCLUMPING
+	if ((clump = mem->clump))
 	{
-		if (*memchainpointer == mem)
+		if (clump->sentinel1 != MEMCLUMP_SENTINEL)
+			Sys_Error("Mem_Free: trashed clump sentinel 1 (free at %s:%i)", filename, fileline);
+		if (clump->sentinel2 != MEMCLUMP_SENTINEL)
+			Sys_Error("Mem_Free: trashed clump sentinel 2 (free at %s:%i)", filename, fileline);
+		firstblock = ((qbyte *) mem - (qbyte *) clump->block);
+		if (firstblock & (MEMUNIT - 1))
+			Sys_Error("Mem_Free: address not valid in clump (free at %s:%i)", filename, fileline);
+		firstblock /= MEMUNIT;
+		endblock = firstblock + ((sizeof(memheader_t) + mem->size + sizeof(int) + (MEMUNIT - 1)) / MEMUNIT);
+		clump->blocksinuse -= endblock - firstblock;
+		// could use &, but we know the bit is set
+		for (i = firstblock;i < endblock;i++)
+			clump->bits[i >> 5] -= (1 << (i & 31));
+		if (clump->blocksinuse <= 0)
 		{
-			*memchainpointer = mem->chain;
-			pool->totalsize -= mem->size;
-#if MEMCLUMPING
-			if ((clump = mem->clump))
+			// unlink from chain
+			for (clumpchainpointer = &pool->clumpchain;*clumpchainpointer;clumpchainpointer = &(*clumpchainpointer)->chain)
 			{
-				if (clump->sentinel1 != MEMCLUMP_SENTINEL)
-					Sys_Error("Mem_Free: trashed clump sentinel 1 (free at %s:%i)", filename, fileline);
-				if (clump->sentinel2 != MEMCLUMP_SENTINEL)
-					Sys_Error("Mem_Free: trashed clump sentinel 2 (free at %s:%i)", filename, fileline);
-				firstblock = ((qbyte *) mem - (qbyte *) clump->block);
-				if (firstblock & (MEMUNIT - 1))
-					Sys_Error("Mem_Free: address not valid in clump (free at %s:%i)", filename, fileline);
-				firstblock /= MEMUNIT;
-				endblock = firstblock + ((sizeof(memheader_t) + mem->size + sizeof(int) + (MEMUNIT - 1)) / MEMUNIT);
-				clump->blocksinuse -= endblock - firstblock;
-				// could use &, but we know the bit is set
-				for (i = firstblock;i < endblock;i++)
-					clump->bits[i >> 5] -= (1 << (i & 31));
-				if (clump->blocksinuse <= 0)
-				{
-					// unlink from chain
-					for (clumpchainpointer = &pool->clumpchain;*clumpchainpointer;clumpchainpointer = &(*clumpchainpointer)->chain)
-					{
-						if (*clumpchainpointer == clump)
-						{
-							*clumpchainpointer = clump->chain;
-							break;
-						}
-					}
-					pool->realsize -= sizeof(memclump_t);
-					memset(clump, 0xBF, sizeof(memclump_t));
-					free(clump);
-				}
-				else
+				if (*clumpchainpointer == clump)
 				{
-					// clump still has some allocations
-					// force re-check of largest available space on next alloc
-					clump->largestavailable = MEMBITS - clump->blocksinuse;
+					*clumpchainpointer = clump->chain;
+					break;
 				}
 			}
-			else
-			{
+			pool->realsize -= sizeof(memclump_t);
+			memset(clump, 0xBF, sizeof(memclump_t));
+			free(clump);
+		}
+		else
+		{
+			// clump still has some allocations
+			// force re-check of largest available space on next alloc
+			clump->largestavailable = MEMBITS - clump->blocksinuse;
+		}
+	}
+	else
+	{
 #endif
-				pool->realsize -= sizeof(memheader_t) + mem->size + sizeof(int);
-				memset(mem, 0xBF, sizeof(memheader_t) + mem->size + sizeof(int));
-				free(mem);
+		pool->realsize -= sizeof(memheader_t) + mem->size + sizeof(int);
+		memset(mem, 0xBF, sizeof(memheader_t) + mem->size + sizeof(int));
+		free(mem);
 #if MEMCLUMPING
-			}
-#endif
-			return;
-		}
 	}
-	Sys_Error("Mem_Free: not allocated (free at %s:%i)", filename, fileline);
+#endif
 }
 
-mempool_t *_Mem_AllocPool(char *name, char *filename, int fileline)
+mempool_t *_Mem_AllocPool(const char *name, const char *filename, int fileline)
 {
 	mempool_t *pool;
 	pool = malloc(sizeof(mempool_t));
 	if (pool == NULL)
 		Sys_Error("Mem_AllocPool: out of memory (allocpool at %s:%i)", filename, fileline);
 	memset(pool, 0, sizeof(mempool_t));
+	pool->sentinel1 = MEMHEADER_SENTINEL1;
+	pool->sentinel2 = MEMHEADER_SENTINEL1;
+	pool->filename = filename;
+	pool->fileline = fileline;
 	pool->chain = NULL;
 	pool->totalsize = 0;
 	pool->realsize = sizeof(mempool_t);
@@ -210,11 +217,15 @@ mempool_t *_Mem_AllocPool(char *name, char *filename, int fileline)
 	return pool;
 }
 
-void _Mem_FreePool(mempool_t **pool, char *filename, int fileline)
+void _Mem_FreePool(mempool_t **pool, const char *filename, int fileline)
 {
 	mempool_t **chainaddress;
 	if (*pool)
 	{
+		if ((*pool)->sentinel1 != MEMHEADER_SENTINEL1)
+			Sys_Error("Mem_FreePool: trashed pool sentinel 1 (allocpool at %s:%i, freepool at %s:%i)", (*pool)->filename, (*pool)->fileline, filename, fileline);
+		if ((*pool)->sentinel2 != MEMHEADER_SENTINEL1)
+			Sys_Error("Mem_FreePool: trashed pool sentinel 2 (allocpool at %s:%i, freepool at %s:%i)", (*pool)->filename, (*pool)->fileline, filename, fileline);
 		// unlink pool from chain
 		for (chainaddress = &poolchain;*chainaddress && *chainaddress != *pool;chainaddress = &((*chainaddress)->next));
 		if (*chainaddress != *pool)
@@ -232,17 +243,21 @@ void _Mem_FreePool(mempool_t **pool, char *filename, int fileline)
 	}
 }
 
-void _Mem_EmptyPool(mempool_t *pool, char *filename, int fileline)
+void _Mem_EmptyPool(mempool_t *pool, const char *filename, int fileline)
 {
 	if (pool == NULL)
 		Sys_Error("Mem_EmptyPool: pool == NULL (emptypool at %s:%i)", filename, fileline);
+	if (pool->sentinel1 != MEMHEADER_SENTINEL1)
+		Sys_Error("Mem_EmptyPool: trashed pool sentinel 1 (allocpool at %s:%i, emptypool at %s:%i)", pool->filename, pool->fileline, filename, fileline);
+	if (pool->sentinel2 != MEMHEADER_SENTINEL1)
+		Sys_Error("Mem_EmptyPool: trashed pool sentinel 2 (allocpool at %s:%i, emptypool at %s:%i)", pool->filename, pool->fileline, filename, fileline);
 
 	// free memory owned by the pool
 	while (pool->chain)
 		Mem_Free((void *)((qbyte *) pool->chain + sizeof(memheader_t)));
 }
 
-void _Mem_CheckSentinels(void *data, char *filename, int fileline)
+void _Mem_CheckSentinels(void *data, const char *filename, int fileline)
 {
 	memheader_t *mem;
 
@@ -257,7 +272,7 @@ void _Mem_CheckSentinels(void *data, char *filename, int fileline)
 }
 
 #if MEMCLUMPING
-static void _Mem_CheckClumpSentinels(memclump_t *clump, char *filename, int fileline)
+static void _Mem_CheckClumpSentinels(memclump_t *clump, const char *filename, int fileline)
 {
 	// this isn't really very useful
 	if (clump->sentinel1 != MEMCLUMP_SENTINEL)
@@ -267,7 +282,7 @@ static void _Mem_CheckClumpSentinels(memclump_t *clump, char *filename, int file
 }
 #endif
 
-void _Mem_CheckSentinelsGlobal(char *filename, int fileline)
+void _Mem_CheckSentinelsGlobal(const char *filename, int fileline)
 {
 	memheader_t *mem;
 #if MEMCLUMPING
@@ -275,15 +290,19 @@ void _Mem_CheckSentinelsGlobal(char *filename, int fileline)
 #endif
 	mempool_t *pool;
 	for (pool = poolchain;pool;pool = pool->next)
-#if MEMCLUMPING
 	{
-#endif
-		for (mem = pool->chain;mem;mem = mem->chain)
+		if (pool->sentinel1 != MEMHEADER_SENTINEL1)
+			Sys_Error("Mem_CheckSentinelsGlobal: trashed pool sentinel 1 (allocpool at %s:%i, sentinel check at %s:%i)", pool->filename, pool->fileline, filename, fileline);
+		if (pool->sentinel2 != MEMHEADER_SENTINEL1)
+			Sys_Error("Mem_CheckSentinelsGlobal: trashed pool sentinel 2 (allocpool at %s:%i, sentinel check at %s:%i)", pool->filename, pool->fileline, filename, fileline);
+	}
+	for (pool = poolchain;pool;pool = pool->next)
+		for (mem = pool->chain;mem;mem = mem->next)
 			_Mem_CheckSentinels((void *)((qbyte *) mem + sizeof(memheader_t)), filename, fileline);
 #if MEMCLUMPING
+	for (pool = poolchain;pool;pool = pool->next)
 		for (clump = pool->clumpchain;clump;clump = clump->chain)
 			_Mem_CheckClumpSentinels(clump, filename, fileline);
-	}
 #endif
 }
 
@@ -312,7 +331,7 @@ void Mem_PrintStats(void)
 	{
 		Con_Printf("%i bytes (%.3fMB) of temporary memory still allocated (Leak!)\n", tempmempool->totalsize, tempmempool->totalsize / 1048576.0);
 		Con_Printf("listing temporary memory allocations:\n");
-		for (mem = tempmempool->chain;mem;mem = mem->chain)
+		for (mem = tempmempool->chain;mem;mem = mem->next)
 			Con_Printf("%10i bytes allocated at %s:%i\n", mem->size, mem->filename, mem->fileline);
 	}
 }
@@ -332,7 +351,7 @@ void Mem_PrintList(int listallocations)
 			Con_Printf("%6ik (%6ik actual) %s\n", (pool->totalsize + 1023) / 1024, (pool->realsize + 1023) / 1024, pool->name);
 		pool->lastchecksize = pool->totalsize;
 		if (listallocations)
-			for (mem = pool->chain;mem;mem = mem->chain)
+			for (mem = pool->chain;mem;mem = mem->next)
 				Con_Printf("%10i bytes allocated at %s:%i\n", mem->size, mem->filename, mem->fileline);
 	}
 }