X-Git-Url: http://git.xonotic.org/?a=blobdiff_plain;f=image.c;h=c556f3930bfbc7cd0170ceaeeb439908673d9718;hb=2000fe0dea529231a494c63436f171829cbf43e5;hp=2f805795b4c32f6e2da79f05e8e59a4e5f3a1528;hpb=b15cc6cadea920bb80849ef07fa72622b1a75b69;p=xonotic%2Fdarkplaces.git diff --git a/image.c b/image.c index 2f805795..c556f393 100644 --- a/image.c +++ b/image.c @@ -8,6 +8,14 @@ int image_width; int image_height; +void Image_CopyAlphaFromBlueBGRA(unsigned char *outpixels, const unsigned char *inpixels, int w, int h) +{ + int i, n; + n = w * h; + for(i = 0; i < n; ++i) + outpixels[4*i+3] = inpixels[4*i]; // blue channel +} + #if 1 // written by LordHavoc in a readable way, optimized by Vic, further optimized by LordHavoc (the non-special index case), readable version preserved below this void Image_CopyMux(unsigned char *outpixels, const unsigned char *inpixels, int inputwidth, int inputheight, qboolean inputflipx, qboolean inputflipy, qboolean inputflipdiagonal, int numoutputcomponents, int numinputcomponents, int *outputinputcomponentindices) @@ -181,7 +189,7 @@ typedef struct pcx_s LoadPCX ============ */ -unsigned char* LoadPCX_BGRA (const unsigned char *f, int filesize) +unsigned char* LoadPCX_BGRA (const unsigned char *f, int filesize, int *miplevel) { pcx_t pcx; unsigned char *a, *b, *image_buffer, *pbuf; @@ -211,7 +219,7 @@ unsigned char* LoadPCX_BGRA (const unsigned char *f, int filesize) image_width = pcx.xmax + 1 - pcx.xmin; image_height = pcx.ymax + 1 - pcx.ymin; - if (pcx.manufacturer != 0x0a || pcx.version != 5 || pcx.encoding != 1 || pcx.bits_per_pixel != 8 || image_width > 4096 || image_height > 4096 || image_width <= 0 || image_height <= 0) + if (pcx.manufacturer != 0x0a || pcx.version != 5 || pcx.encoding != 1 || pcx.bits_per_pixel != 8 || image_width > 32768 || image_height > 32768 || image_width <= 0 || image_height <= 0) { Con_Print("Bad pcx file\n"); return NULL; @@ -374,7 +382,7 @@ void PrintTargaHeader(TargaHeader *t) LoadTGA ============= */ -unsigned char *LoadTGA_BGRA (const unsigned char *f, int filesize) +unsigned char *LoadTGA_BGRA (const unsigned char *f, int filesize, int *miplevel) { int x, y, pix_inc, row_inci, runlen, alphabits; unsigned char *image_buffer; @@ -408,7 +416,7 @@ unsigned char *LoadTGA_BGRA (const unsigned char *f, int filesize) targa_header.pixel_size = f[16]; targa_header.attributes = f[17]; - if (image_width > 4096 || image_height > 4096 || image_width <= 0 || image_height <= 0) + if (image_width > 32768 || image_height > 32768 || image_width <= 0 || image_height <= 0) { Con_Print("LoadTGA: invalid size\n"); PrintTargaHeader(&targa_header); @@ -601,6 +609,13 @@ unsigned char *LoadTGA_BGRA (const unsigned char *f, int filesize) *pixbufi++ = palettei[*fin++]; } } + + if (x != image_width) + { + // pixbufi is useless now + Con_Printf("LoadTGA: corrupt file\n"); + break; + } } break; case 10: @@ -649,6 +664,13 @@ unsigned char *LoadTGA_BGRA (const unsigned char *f, int filesize) } } } + + if (x != image_width) + { + // pixbufi is useless now + Con_Printf("LoadTGA: corrupt file\n"); + break; + } } } else @@ -695,6 +717,13 @@ unsigned char *LoadTGA_BGRA (const unsigned char *f, int filesize) } } } + + if (x != image_width) + { + // pixbufi is useless now + Con_Printf("LoadTGA: corrupt file\n"); + break; + } } } break; @@ -717,7 +746,7 @@ typedef struct q2wal_s int value; } q2wal_t; -unsigned char *LoadWAL_BGRA (const unsigned char *f, int filesize) +unsigned char *LoadWAL_BGRA (const unsigned char *f, int filesize, int *miplevel) { unsigned char *image_buffer; const q2wal_t *inwal = (const q2wal_t *)f; @@ -730,7 +759,7 @@ unsigned char *LoadWAL_BGRA (const unsigned char *f, int filesize) image_width = LittleLong(inwal->width); image_height = LittleLong(inwal->height); - if (image_width > 4096 || image_height > 4096 || image_width <= 0 || image_height <= 0) + if (image_width > 32768 || image_height > 32768 || image_width <= 0 || image_height <= 0) { Con_Printf("LoadWAL: invalid size %ix%i\n", image_width, image_height); return NULL; @@ -767,10 +796,28 @@ void Image_StripImageExtension (const char *in, char *out, size_t size_out) strlcpy(out, in, size_out); } +static unsigned char image_linearfromsrgb[256]; + +void Image_MakeLinearColorsFromsRGB(unsigned char *pout, const unsigned char *pin, int numpixels) +{ + int i; + // this math from http://www.opengl.org/registry/specs/EXT/texture_sRGB.txt + if (!image_linearfromsrgb[255]) + for (i = 0;i < 256;i++) + image_linearfromsrgb[i] = (unsigned char)(Image_LinearFloatFromsRGB(i) * 256.0f); + for (i = 0;i < numpixels;i++) + { + pout[i*4+0] = image_linearfromsrgb[pin[i*4+0]]; + pout[i*4+1] = image_linearfromsrgb[pin[i*4+1]]; + pout[i*4+2] = image_linearfromsrgb[pin[i*4+2]]; + pout[i*4+3] = pin[i*4+3]; + } +} + typedef struct imageformat_s { const char *formatstring; - unsigned char *(*loadfunc)(const unsigned char *f, int filesize); + unsigned char *(*loadfunc)(const unsigned char *f, int filesize, int *miplevel); } imageformat_t; @@ -846,12 +893,12 @@ imageformat_t imageformats_other[] = }; int fixtransparentpixels(unsigned char *data, int w, int h); -unsigned char *loadimagepixelsbgra (const char *filename, qboolean complain, qboolean allowFixtrans) +unsigned char *loadimagepixelsbgra (const char *filename, qboolean complain, qboolean allowFixtrans, qboolean convertsRGB, int *miplevel) { fs_offset_t filesize; imageformat_t *firstformat, *format; - unsigned char *f, *data = NULL; - char basename[MAX_QPATH], name[MAX_QPATH], *c; + unsigned char *f, *data = NULL, *data2 = NULL; + char basename[MAX_QPATH], name[MAX_QPATH], name2[MAX_QPATH], *c; //if (developer_memorydebug.integer) // Mem_CheckSentinelsGlobal(); if (developer_texturelogging.integer) @@ -888,12 +935,30 @@ unsigned char *loadimagepixelsbgra (const char *filename, qboolean complain, qbo f = FS_LoadFile(name, tempmempool, true, &filesize); if (f) { - data = format->loadfunc(f, filesize); + int mymiplevel = miplevel ? *miplevel : 0; + data = format->loadfunc(f, (int)filesize, &mymiplevel); Mem_Free(f); if (data) { - if (developer.integer >= 10) - Con_Printf("loaded image %s (%dx%d)\n", name, image_width, image_height); + if(format->loadfunc == JPEG_LoadImage_BGRA) // jpeg can't do alpha, so let's simulate it by loading another jpeg + { + dpsnprintf (name2, sizeof(name2), format->formatstring, va("%s_alpha", basename)); + f = FS_LoadFile(name2, tempmempool, true, &filesize); + if(f) + { + int mymiplevel2 = miplevel ? *miplevel : 0; + data2 = format->loadfunc(f, (int)filesize, &mymiplevel2); + if(mymiplevel != mymiplevel2) + Host_Error("loadimagepixelsbgra: miplevels differ"); + Mem_Free(f); + Image_CopyAlphaFromBlueBGRA(data, data2, image_width, image_height); + Mem_Free(data2); + } + } + if (developer_loading.integer) + Con_DPrintf("loaded image %s (%dx%d)\n", name, image_width, image_height); + if(miplevel) + *miplevel = mymiplevel; //if (developer_memorydebug.integer) // Mem_CheckSentinelsGlobal(); if(allowFixtrans && r_fixtrans_auto.integer) @@ -912,6 +977,8 @@ unsigned char *loadimagepixelsbgra (const char *filename, qboolean complain, qbo } } } + if (convertsRGB) + Image_MakeLinearColorsFromsRGB(data, data, image_width * image_height); return data; } else @@ -936,13 +1003,15 @@ unsigned char *loadimagepixelsbgra (const char *filename, qboolean complain, qbo return NULL; } -rtexture_t *loadtextureimage (rtexturepool_t *pool, const char *filename, qboolean complain, int flags, qboolean allowFixtrans) +extern cvar_t gl_picmip; +rtexture_t *loadtextureimage (rtexturepool_t *pool, const char *filename, qboolean complain, int flags, qboolean allowFixtrans, qboolean sRGB) { unsigned char *data; rtexture_t *rt; - if (!(data = loadimagepixelsbgra (filename, complain, allowFixtrans))) + int miplevel = R_PicmipForFlags(flags); + if (!(data = loadimagepixelsbgra (filename, complain, allowFixtrans, false, &miplevel))) return 0; - rt = R_LoadTexture2D(pool, filename, image_width, image_height, data, TEXTYPE_BGRA, flags, NULL); + rt = R_LoadTexture2D(pool, filename, image_width, image_height, data, sRGB ? TEXTYPE_SRGB_BGRA : TEXTYPE_BGRA, flags, miplevel, NULL); Mem_Free(data); return rt; } @@ -1088,7 +1157,7 @@ void Image_FixTransparentPixels_f(void) Con_Printf("Processing %s... ", filename); Image_StripImageExtension(filename, buf, sizeof(buf)); dpsnprintf(outfilename, sizeof(outfilename), "fixtrans/%s.tga", buf); - if(!(data = loadimagepixelsbgra(filename, true, false))) + if(!(data = loadimagepixelsbgra(filename, true, false, false, NULL))) return; if((n = fixtransparentpixels(data, image_width, image_height))) { @@ -1102,9 +1171,12 @@ void Image_FixTransparentPixels_f(void) FS_FreeSearch(search); } -qboolean Image_WriteTGABGR_preflipped (const char *filename, int width, int height, const unsigned char *data, unsigned char *buffer) +qboolean Image_WriteTGABGR_preflipped (const char *filename, int width, int height, const unsigned char *data) { qboolean ret; + unsigned char buffer[18]; + const void *buffers[2]; + fs_offset_t sizes[2]; memset (buffer, 0, 18); buffer[2] = 2; // uncompressed type @@ -1114,18 +1186,21 @@ qboolean Image_WriteTGABGR_preflipped (const char *filename, int width, int heig buffer[15] = (height >> 8) & 0xFF; buffer[16] = 24; // pixel size - // swap rgb to bgr - memcpy(buffer + 18, data, width*height*3); - ret = FS_WriteFile (filename, buffer, width*height*3 + 18 ); + buffers[0] = buffer; + sizes[0] = 18; + buffers[1] = data; + sizes[1] = width*height*3; + ret = FS_WriteFileInBlocks(filename, buffers, sizes, 2); return ret; } -void Image_WriteTGABGRA (const char *filename, int width, int height, const unsigned char *data) +qboolean Image_WriteTGABGRA (const char *filename, int width, int height, const unsigned char *data) { int y; unsigned char *buffer, *out; const unsigned char *in, *end; + qboolean ret; buffer = (unsigned char *)Mem_Alloc(tempmempool, width*height*4 + 18); @@ -1174,9 +1249,11 @@ void Image_WriteTGABGRA (const char *filename, int width, int height, const unsi } } } - FS_WriteFile (filename, buffer, out - buffer); + ret = FS_WriteFile (filename, buffer, out - buffer); Mem_Free(buffer); + + return ret; } static void Image_Resample32LerpLine (const unsigned char *in, unsigned char *out, int inwidth, int outwidth) @@ -1457,9 +1534,7 @@ void Image_HeightmapToNormalmap_BGRA(const unsigned char *inpixels, unsigned cha const unsigned char *b, *row[3]; int p[5]; unsigned char *out; - float iwidth, iheight, ibumpscale, n[3]; - iwidth = 1.0f / width; - iheight = 1.0f / height; + float ibumpscale, n[3]; ibumpscale = (255.0f * 6.0f) / bumpscale; out = outpixels; for (y = 0, y1 = height-1;y < height;y1 = y, y++)