X-Git-Url: http://git.xonotic.org/?a=blobdiff_plain;f=cl_gecko.c;h=b4f6542a53b3071cfaaa178c520edd3c330d5ff3;hb=3a4442bb1e483ecfa526b6ce091de4f8b98461b8;hp=aca0cbfba89ad2f883423ec06b2511f81c949548;hpb=76bdf43c2fbbd31091fd71baeba9ade7596d9292;p=xonotic%2Fdarkplaces.git

diff --git a/cl_gecko.c b/cl_gecko.c
index aca0cbfb..b4f6542a 100644
--- a/cl_gecko.c
+++ b/cl_gecko.c
@@ -325,7 +325,7 @@ OSGK_DERIVEDTYPE(OSGK_ScriptObjectTemplate);
 typedef enum OSGK_ScriptResult
 {
   srSuccess = 0,
-  srFailed = 0x80004005L /* actually NS_ERROR_FAILURE */
+  srFailed = (int)0x80004005L /* actually NS_ERROR_FAILURE */
 } OSGK_ScriptResult;
 
 typedef struct OSGK_ScriptObjectCreateParams_s
@@ -405,9 +405,7 @@ static clgecko_t * cl_gecko_findunusedinstance( void ) {
 			return instance;
 		}
 	}
-	if( developer.integer > 0 ) {
-		Con_Printf( "cl_gecko_findunusedinstance: out of geckos\n" );
-	}
+	Con_DPrintf( "cl_gecko_findunusedinstance: out of geckos\n" );
 	return NULL;
 }
 
@@ -415,9 +413,7 @@ clgecko_t * CL_Gecko_FindBrowser( const char *name ) {
 	int i;
 
 	if( !name || !*name || strncmp( name, CLGECKOPREFIX, sizeof( CLGECKOPREFIX ) - 1 ) != 0 ) {
-		if( developer.integer > 0 ) {
-			Con_Printf( "CL_Gecko_FindBrowser: Bad gecko texture name '%s'!\n", name );
-		}
+		Con_DPrintf( "CL_Gecko_FindBrowser: Bad gecko texture name '%s'!\n", name );
 		return NULL;
 	}
 
@@ -428,15 +424,13 @@ clgecko_t * CL_Gecko_FindBrowser( const char *name ) {
 		}
 	}
 
-	if( developer.integer > 0 ) {
-		Con_Printf( "CL_Gecko_FindBrowser: No browser named '%s'!\n", name );
-	}
+	Con_DPrintf( "CL_Gecko_FindBrowser: No browser named '%s'!\n", name );
 
 	return NULL;
 }
 
 static void cl_gecko_updatecallback( rtexture_t *texture, void* callbackData ) {
-	clgecko_t *instance = callbackData;
+	clgecko_t *instance = (clgecko_t *) callbackData;
 	const unsigned char *data;
 	if( instance->browser ) {
 		// TODO: OSGK only supports BGRA right now
@@ -449,7 +443,7 @@ static void cl_gecko_updatecallback( rtexture_t *texture, void* callbackData ) {
 static void cl_gecko_linktexture( clgecko_t *instance ) {
 	// TODO: assert that instance->texture == NULL
 	instance->texture = R_LoadTexture2D( cl_geckotexturepool, instance->name, 
-		instance->texWidth, instance->texHeight, NULL, TEXTYPE_BGRA, TEXF_ALPHA | TEXF_PERSISTENT, NULL );
+		instance->texWidth, instance->texHeight, NULL, TEXTYPE_BGRA, TEXF_ALPHA | TEXF_PERSISTENT | TEXF_ALLOWUPDATES, NULL );
 	R_MakeTextureDynamic( instance->texture, cl_gecko_updatecallback, instance );
 	CL_LinkDynTexture( instance->name, instance->texture );
 }
@@ -514,7 +508,7 @@ static OSGK_ScriptResult dpGlobal_query (void* objTag, void* methTag,
 					 OSGK_ScriptVariant** params,
 					 OSGK_ScriptVariant** returnVal)
 {
-  clgecko_t *instance = objTag;
+  clgecko_t *instance = (clgecko_t *) objTag;
   OSGK_ScriptVariant* strVal;
   OSGK_ScriptResult result = srFailed;
   prvm_prog_t * saveProg;
@@ -551,7 +545,7 @@ static OSGK_ScriptResult dpGlobal_query (void* objTag, void* methTag,
   return result;
 }
 
-#if defined(WIN64)
+#if defined(_WIN64)
 # define XULRUNNER_DIR_SUFFIX	"win64"
 #elif defined(WIN32)
 # define XULRUNNER_DIR_SUFFIX	"win32"
@@ -570,9 +564,7 @@ static qboolean CL_Gecko_Embedding_Init (void)
 
 	if( cl_geckoembedding != NULL ) return true;
 
-	if( developer.integer > 0 ) {
-		Con_Printf( "CL_Gecko_Embedding_Init: setting up gecko embedding\n" );
-	}
+	Con_DPrintf( "CL_Gecko_Embedding_Init: setting up gecko embedding\n" );
 
 	options = osgk_embedding_options_create();
 #ifdef XULRUNNER_DIR_SUFFIX
@@ -589,9 +581,7 @@ static qboolean CL_Gecko_Embedding_Init (void)
 		return false;
 	} 
 	
-	if( developer.integer > 0 ) {
-		Con_Printf( "CL_Gecko_Embedding_Init: Embedding set up correctly\n" );
-	}
+	Con_DPrintf( "CL_Gecko_Embedding_Init: Embedding set up correctly\n" );
 
 	dpGlobalTemplate = osgk_sot_create( cl_geckoembedding, dpGlobal_create, NULL, NULL );
 
@@ -716,8 +706,7 @@ static void cl_gecko_create_f( void ) {
 		return;
 	}
 
-	// TODO: use snprintf instead
-	sprintf(name, CLGECKOPREFIX "%s", Cmd_Argv(1));
+	dpsnprintf(name, sizeof(name), CLGECKOPREFIX "%s", Cmd_Argv(1));
 	CL_Gecko_CreateBrowser( name, -1 );
 }
 
@@ -730,8 +719,7 @@ static void cl_gecko_destroy_f( void ) {
 		return;
 	}
 
-	// TODO: use snprintf instead
-	sprintf(name, CLGECKOPREFIX "%s", Cmd_Argv(1));
+	dpsnprintf(name, sizeof(name), CLGECKOPREFIX "%s", Cmd_Argv(1));
 	CL_Gecko_DestroyBrowser( CL_Gecko_FindBrowser( name ) );
 }
 
@@ -745,8 +733,7 @@ static void cl_gecko_navigate_f( void ) {
 		return;
 	}
 
-	// TODO: use snprintf instead
-	sprintf(name, CLGECKOPREFIX "%s", Cmd_Argv(1));
+	dpsnprintf(name, sizeof(name), CLGECKOPREFIX "%s", Cmd_Argv(1));
 	URI = Cmd_Argv( 2 );
 	CL_Gecko_NavigateToURI( CL_Gecko_FindBrowser( name ), URI );
 }
@@ -763,8 +750,7 @@ static void cl_gecko_injecttext_f( void ) {
 		return;
 	}
 
-	// TODO: use snprintf instead
-	sprintf(name, CLGECKOPREFIX "%s", Cmd_Argv(1));
+	dpsnprintf(name, sizeof(name), CLGECKOPREFIX "%s", Cmd_Argv(1));
 	instance = CL_Gecko_FindBrowser( name );
 	if( !instance ) {
 		Con_Printf( "cl_gecko_injecttext_f: gecko instance '%s' couldn't be found!\n", name );
@@ -793,7 +779,7 @@ static void cl_gecko_injecttext_f( void ) {
 				break;
 		}
 
-		CL_Gecko_Event_Key( instance, key, CLG_BET_PRESS );
+		CL_Gecko_Event_Key( instance, (keynum_t) key, CLG_BET_PRESS );
 	}
 }
 
@@ -807,8 +793,7 @@ static void gl_gecko_movecursor_f( void ) {
 		return;
 	}
 
-	// TODO: use snprintf instead
-	sprintf(name, CLGECKOPREFIX "%s", Cmd_Argv(1));
+	dpsnprintf(name, sizeof(name), CLGECKOPREFIX "%s", Cmd_Argv(1));
 	x = atof( Cmd_Argv( 2 ) );
 	y = atof( Cmd_Argv( 3 ) );
 
@@ -849,29 +834,34 @@ static const dllfunction_t osgkFuncs[] =
 	{NULL, NULL}
 };
 
-void CL_Gecko_Init( void )
+qboolean CL_Gecko_OpenLibrary (void)
 {
-	const char* dllnames [] =
+	const char* dllnames_gecko [] =
 	{
-	#if defined(WIN64)
-		"OffscreenGecko64.dll",
-	#elif defined(WIN32)
+#if defined(WIN32)
 		"OffscreenGecko.dll",
-	#elif defined(MACOSX)
+#elif defined(MACOSX)
 		"OffscreenGecko.dylib",
-	#else
+#else
 		"libOffscreenGecko.so",
-	#endif
+#endif
 		NULL
 	};
-	
-	if (!osgk_dll)
-	{
-		if (! Sys_LoadLibrary (dllnames, &osgk_dll, osgkFuncs))
-		{
-			Con_Printf ("Could not load OffscreenGecko, Gecko support unavailable\n");
-		}
-	}
+
+	// Already loaded?
+	if (osgk_dll)
+		return true;
+
+// COMMANDLINEOPTION: Sound: -nogecko disables gecko support (web browser support for menu and computer terminals)
+	if (COM_CheckParm("-nogecko"))
+		return false;
+
+	return Sys_LoadLibrary (dllnames_gecko, &osgk_dll, osgkFuncs);
+}
+
+void CL_Gecko_Init( void )
+{
+	CL_Gecko_OpenLibrary();
 
 	Cmd_AddCommand( "gecko_create", cl_gecko_create_f, "Create a gecko browser instance" );
 	Cmd_AddCommand( "gecko_destroy", cl_gecko_destroy_f, "Destroy a gecko browser instance" );
@@ -900,8 +890,8 @@ void CL_Gecko_Event_CursorMove( clgecko_t *instance, float x, float y ) {
 		return;
 	}
 
-	mappedx = x * instance->width;
-	mappedy = y * instance->height;
+	mappedx = (int) (x * instance->width);
+	mappedy = (int) (y * instance->height);
 	osgk_browser_event_mouse_move( instance->browser, mappedx, mappedy );
 }