]> git.xonotic.org Git - xonotic/xonotic-data.pk3dir.git/blobdiff - qcsrc/server/g_damage.qc
Make a separate "MSG_DEATH" notification category, cleans up stuff a bit
[xonotic/xonotic-data.pk3dir.git] / qcsrc / server / g_damage.qc
index 989d6fa0ac75256c17ccbe867237b529e6b0a95e..65b0ebc226b0ec1add31490487f72d9fc26d253c 100644 (file)
@@ -297,7 +297,7 @@ void LogDeath(string mode, float deathtype, entity killer, entity killed)
        s = strcat(":kill:", mode);
        s = strcat(s, ":", ftos(killer.playerid));
        s = strcat(s, ":", ftos(killed.playerid));
-       s = strcat(s, ":type=", ftos(deathtype));
+       s = strcat(s, ":type=", Deathtype_Name(deathtype));
        s = strcat(s, ":items=");
        s = AppendItemcodes(s, killer);
        if(killed != killer)
@@ -308,46 +308,75 @@ void LogDeath(string mode, float deathtype, entity killer, entity killed)
        GameLogEcho(s);
 }
 
-string Deathtype_Name(float deathtype)
+void Obituary_SpecialDeath(entity notif_target, float murder, float deathtype, string s1, string s2, float f1, float f2, float f3)
 {
+       float handled, hits;
        if(DEATH_ISSPECIAL(deathtype))
        {
-               #define DEATHTYPE(name,msg_info,msg_center,position) \
-                       { if(deathtype == max(0, name)) return VAR_TO_TEXT(name); }
+               #define DEATHTYPE(name,msg_death_by,msg_death,position) \
+                       { if(deathtype == max(0, name)) \
+                       { \
+                               #if murder \
+                                       if(max(0, msg_death_by)) { Send_Notification(notif_target, MSG_ONE, MSG_DEATH, msg_death_by, s1, s2, f1, f2, f3); ++handled; } \
+                               #else \
+                                       if(max(0, msg_death)) { Send_Notification(notif_target, MSG_ONE, MSG_DEATH, msg_death, s1, s2, f1, f2, f3); ++handled; } \
+                               #endif \
+                               ++hits; \
+                       } }
 
                DEATHTYPES
+               if not(hits)
+               {
+                       backtrace("Unhandled deathtype. Please notify Samual!\n");
+                       //return;
+               }
+               if not(handled)
+               {
+                       print(sprintf("Obituary_SpecialDeath(): ^1Deathtype ^7(%s-%d)^1 has no notification!\n", Deathtype_Name(deathtype), deathtype));
+                       return;
+               }
        }
-       return "foobar";
 }
 
-void Obituary_SpecialDeath(entity notif_target, float deathtype, string s1, string s2, float f1, float f2, float f3)
+void Obituary_WeaponDeath(entity notif_target, float deathtype, string s1, string s2, float f1, float f2, float f3)
 {
+       float handled, hits;
        if(DEATH_ISSPECIAL(deathtype))
        {
-               #define DEATHTYPE(name,msg_info,msg_center,position) \
+               #define DEATHTYPE(name,msg_death_by,msg_death,position) \
                        { if(deathtype == max(0, name)) \
                        { \
-                               if(max(0, msg_info)) { Send_Notification(world, MSG_INFO, msg_info, s1, s2, f1, f2, f3); } \
-                               if(max(0, msg_center)) { Send_Notification(notif_target, MSG_CENTER, msg_center, s1, s2, f1, f2, f3); } \
-                               return; \
+                               ++hits; \
                        } }
 
                DEATHTYPES
-               backtrace("Unhandled deathtype. Please notify Samual!\n");
+               if not(hits)
+               {
+                       backtrace("Unhandled deathtype. Please notify Samual!\n");
+                       //return;
+               }
+               if not(handled)
+               {
+                       print(sprintf("Obituary_SpecialDeath(): ^1Deathtype ^7(%s-%d)^1 has no notification!\n", Deathtype_Name(deathtype), deathtype));
+                       return;
+               }
        }
 }
 
+.float FRAG_VERBOSE;
+
 void Obituary(entity attacker, entity inflictor, entity targ, float deathtype)
 {
        // Sanity check
-       if(targ.classname == "player") { backtrace("Obituary called on non-player?!\n"); return; }
+       if not(targ.classname == "player") { backtrace("Obituary called on non-player?!\n"); return; }
 
        // Declarations
        string  s, a, msg;
        float w, type;
 
-       string s1, s2;
-       float f1, f2, f3;
+       string s1, s2 = NO_STR_ARG;
+       float f1, f2, f3 = NO_FL_ARG;
+       float notif_firstblood;
 
 
        print(sprintf("Obituary(): Deathtype = %s (%d), Attacker = %s, Inflictor = %s, Target = %s...\n", Deathtype_Name(deathtype), deathtype, attacker.netname, inflictor.netname, targ.netname));
@@ -364,30 +393,30 @@ void Obituary(entity attacker, entity inflictor, entity targ, float deathtype)
                        {
                                s1 = targ.netname;
                                f1 = targ.team;
-                               f2 = NO_FL_ARG;
                        }
                        else
                        {
-                               if(deathtype == DEATH_MIRRORDAMAGE)
-                               {
-                                       s1 = targ.netname;
-                                       f1 = targ.team;
-                                       f2 = targ.killcount;
-                               }
-                               else
+                               switch(deathtype)
                                {
-                                       s1 = targ.netname;
-                                       f1 = targ.killcount;
-                                       f2 = NO_FL_ARG;
+                                       case DEATH_MIRRORDAMAGE:
+                                       {
+                                               s1 = targ.netname;
+                                               f1 = targ.team;
+                                               //f2 = targ.killcount;
+                                               break;
+                                       }
+                                       
+                                       default:
+                                       {
+                                               s1 = s2 = NO_STR_ARG;
+                                               f1 = f2 = f3 = NO_FL_ARG;
+                                               break;
+                                       }
                                }
-                               
-                               // Do this manually inside of each if statement where necessary,
-                               // DEATH_TEAMCHANGE and such are not supposed to have this.
                                LogDeath("suicide", deathtype, targ, targ);
                                GiveFrags(attacker, targ, -1, deathtype);
                        }
-
-                       Obituary_SpecialDeath(targ, deathtype, s1, NO_STR_ARG, f1, f2, NO_FL_ARG);
+                       Obituary_SpecialDeath(targ, FALSE, deathtype, s1, s2, f1, f2, NO_FL_ARG);
                }
                else if(DEATH_WEAPONOF(deathtype))
                {
@@ -409,7 +438,7 @@ void Obituary(entity attacker, entity inflictor, entity targ, float deathtype)
                {
                        if(DEATH_ISSPECIAL(deathtype))
                        {
-                               print("hmm death was special?\n");
+                               backtrace("hmm death was special?\n");
                        }
                        else if(DEATH_WEAPONOF(deathtype))
                        {
@@ -425,93 +454,88 @@ void Obituary(entity attacker, entity inflictor, entity targ, float deathtype)
                }
                else
                {
-                       if (!checkrules_firstblood)
-                       {
-                               checkrules_firstblood = TRUE;
-                               Send_KillNotification(a, "", "", KILL_FIRST_BLOOD, MSG_KILL);
-                               // TODO: make these print a newline if they dont
-                               Send_CSQC_KillCenterprint(attacker, "", "", KILL_FIRST_BLOOD, MSG_KILL);
-                               Send_CSQC_KillCenterprint(targ, "", "", KILL_FIRST_VICTIM, MSG_KILL);
-                               PlayerStats_Event(attacker, PLAYERSTATS_ACHIEVEMENT_FIRSTBLOOD, 1);
-                               PlayerStats_Event(targ, PLAYERSTATS_ACHIEVEMENT_FIRSTVICTIM, 1);
-                       }
-
-                       if(targ.istypefrag) {
-                               Send_CSQC_KillCenterprint(attacker, s, Obituary_ExtraFragInfo(targ), KILL_TYPEFRAG, MSG_KILL);
-                               Send_CSQC_KillCenterprint(targ, a, Obituary_ExtraFragInfo(attacker), KILL_TYPEFRAGGED, MSG_KILL);
-                       } else {
-                               Send_CSQC_KillCenterprint(attacker, s, Obituary_ExtraFragInfo(targ), KILL_FRAG, MSG_KILL);
-                               Send_CSQC_KillCenterprint(targ, a, Obituary_ExtraFragInfo(attacker), KILL_FRAGGED, MSG_KILL);
-                       }
-
-                       attacker.taunt_soundtime = time + 1;
-
-                       if (deathtype == DEATH_HURTTRIGGER && inflictor.message2 != "")
-                               msg = inflictor.message2;
-                       else if (deathtype == DEATH_CUSTOM)
-                               msg = deathmessage;
-                       else
-                               msg = "";
-
-                       if(strstrofs(msg, "%", 0) < 0)
-                               msg = strcat("%s ", msg, " by %s");
+                       s1 = attacker.netname;
+                       s2 = targ.netname;
 
-                       Send_KillNotification(a, s, msg, deathtype, MSG_KILL);
+                       attacker.FRAG_VERBOSE = TRUE;
+                       targ.FRAG_VERBOSE = TRUE;
 
+                       LogDeath("frag", deathtype, attacker, targ);
                        GiveFrags(attacker, targ, 1, deathtype);
 
-                       if (targ.killcount > 2) {
-                               Send_KillNotification(s, ftos(targ.killcount), a, KILL_END_SPREE, MSG_SPREE);
-                       }
-
+                       attacker.taunt_soundtime = time + 1;
                        attacker.killcount = attacker.killcount + 1;
-
-                       if (attacker.killcount == 3)
-                       {
-                               Send_KillNotification(a, "", "", KILL_SPREE_3, MSG_SPREE);
-                               AnnounceTo(attacker, "03kills");
-                               PlayerStats_Event(attacker, PLAYERSTATS_ACHIEVEMENT_KILL_SPREE_3, 1);
-                       }
-                       else if (attacker.killcount == 5)
-                       {
-                               Send_KillNotification(a, "", "", KILL_SPREE_5, MSG_SPREE);
-                               AnnounceTo(attacker, "05kills");
-                               PlayerStats_Event(attacker, PLAYERSTATS_ACHIEVEMENT_KILL_SPREE_5, 1);
-                       }
-                       else if (attacker.killcount == 10)
-                       {
-                               Send_KillNotification(a, "", "", KILL_SPREE_10, MSG_SPREE);
-                               AnnounceTo(attacker, "10kills");
-                               PlayerStats_Event(attacker, PLAYERSTATS_ACHIEVEMENT_KILL_SPREE_10, 1);
-                       }
-                       else if (attacker.killcount == 15)
+                       if(targ.killcount > 2) { Send_KillNotification(s, ftos(targ.killcount), a, KILL_END_SPREE, MSG_SPREE); }
+                       
+                       #define ADD_ACHIEVEMENT_CASE(numa,numb) \
+                               case numa: \
+                               { \
+                                       AnnounceTo(attacker, strcat(#numb, "kills")); \
+                                       PlayerStats_Event(attacker, PLAYERSTATS_ACHIEVEMENT_KILL_SPREE_##numa, 1); \
+                                       break; \
+                               }
+                       switch(attacker.killcount)
                        {
-                               Send_KillNotification(a, "", "", KILL_SPREE_15, MSG_SPREE);
-                               AnnounceTo(attacker, "15kills");
-                               PlayerStats_Event(attacker, PLAYERSTATS_ACHIEVEMENT_KILL_SPREE_15, 1);
+                               ADD_ACHIEVEMENT_CASE(3, 03)
+                               ADD_ACHIEVEMENT_CASE(5, 05)
+                               ADD_ACHIEVEMENT_CASE(10, 10)
+                               ADD_ACHIEVEMENT_CASE(15, 15)
+                               ADD_ACHIEVEMENT_CASE(20, 20)
+                               ADD_ACHIEVEMENT_CASE(25, 25)
+                               ADD_ACHIEVEMENT_CASE(30, 30)
+                               default: break;
                        }
-                       else if (attacker.killcount == 20)
+                       #undef ADD_ACHIEVEMENT_CASE
+
+                       if(!checkrules_firstblood)
                        {
-                               Send_KillNotification(a, "", "", KILL_SPREE_20, MSG_SPREE);
-                               AnnounceTo(attacker, "20kills");
-                               PlayerStats_Event(attacker, PLAYERSTATS_ACHIEVEMENT_KILL_SPREE_20, 1);
+                               checkrules_firstblood = TRUE;
+                               notif_firstblood = TRUE; // modify the current messages so that they too show firstblood information
+                               PlayerStats_Event(attacker, PLAYERSTATS_ACHIEVEMENT_FIRSTBLOOD, 1);
+                               PlayerStats_Event(targ, PLAYERSTATS_ACHIEVEMENT_FIRSTVICTIM, 1);
                        }
-                       else if (attacker.killcount == 25)
+
+                       if(notif_firstblood) // first blood, no kill sprees yet
                        {
-                               Send_KillNotification(a, "", "", KILL_SPREE_25, MSG_SPREE);
-                               AnnounceTo(attacker, "25kills");
-                               PlayerStats_Event(attacker, PLAYERSTATS_ACHIEVEMENT_KILL_SPREE_25, 1);
+                               if(targ.istypefrag)
+                               {
+                                       Send_Notification(attacker, MSG_ONE, MSG_DEATH, (attacker.FRAG_VERBOSE ? DEATH_MURDER_TYPEFRAG_FIRST_VERBOSE : DEATH_MURDER_TYPEFRAG_FIRST),
+                                               s2, NO_STR_ARG, (attacker.FRAG_VERBOSE ? ((clienttype(targ) == CLIENTTYPE_BOT) ? BOT_PING : targ.ping) : NO_FL_ARG), NO_FL_ARG, NO_FL_ARG);
+                                               
+                                       Send_Notification(targ, MSG_ONE, MSG_DEATH, (targ.FRAG_VERBOSE ? DEATH_MURDER_TYPEFRAGGED_FIRST_VERBOSE : DEATH_MURDER_TYPEFRAGGED_FIRST),
+                                               s1, NO_STR_ARG, (targ.FRAG_VERBOSE ? attacker.health : NO_FL_ARG), (targ.FRAG_VERBOSE ? attacker.armorvalue : NO_FL_ARG), (targ.FRAG_VERBOSE ? ((clienttype(attacker) == CLIENTTYPE_BOT) ? BOT_PING : attacker.ping) : NO_FL_ARG));
+                               }
+                               else
+                               {
+                                       Send_Notification(attacker, MSG_ONE, MSG_DEATH, (attacker.FRAG_VERBOSE ? DEATH_MURDER_FRAG_FIRST_VERBOSE : DEATH_MURDER_FRAG_FIRST),
+                                               s2, NO_STR_ARG, (attacker.FRAG_VERBOSE ? ((clienttype(targ) == CLIENTTYPE_BOT) ? BOT_PING : targ.ping) : NO_FL_ARG), NO_FL_ARG, NO_FL_ARG);
+                                               
+                                       Send_Notification(targ, MSG_ONE, MSG_DEATH, (targ.FRAG_VERBOSE ? DEATH_MURDER_FRAGGED_FIRST_VERBOSE : DEATH_MURDER_FRAGGED_FIRST),
+                                               s1, NO_STR_ARG, (targ.FRAG_VERBOSE ? attacker.health : NO_FL_ARG), (targ.FRAG_VERBOSE ? attacker.armorvalue : NO_FL_ARG), (targ.FRAG_VERBOSE ? ((clienttype(attacker) == CLIENTTYPE_BOT) ? BOT_PING : attacker.ping) : NO_FL_ARG));
+                               }
+                               //Send_Notification(world, MSG_INFO, INFO_DEATH_FRAG_FIRSTBLOOD, s1, s2, attacker.team, NO_FL_ARG, NO_FL_ARG);
                        }
-                       else if (attacker.killcount == 30)
+                       else // normal frags, kill sprees listed
                        {
-                               Send_KillNotification(a, "", "", KILL_SPREE_30, MSG_SPREE);
-                               AnnounceTo(attacker, "30kills");
-                               PlayerStats_Event(attacker, PLAYERSTATS_ACHIEVEMENT_KILL_SPREE_30, 1);
-                       }
-                       else if (attacker.killcount > 2) {
-                               Send_KillNotification(a, ftos(attacker.killcount), "", KILL_SPREE, MSG_SPREE);
+                               if(targ.istypefrag)
+                               {
+                                       Send_Notification(attacker, MSG_ONE, MSG_DEATH, (attacker.FRAG_VERBOSE ? DEATH_MURDER_TYPEFRAG_VERBOSE : DEATH_MURDER_TYPEFRAG),
+                                               s2, NO_STR_ARG, attacker.killcount, (attacker.FRAG_VERBOSE ? ((clienttype(targ) == CLIENTTYPE_BOT) ? BOT_PING : targ.ping) : NO_FL_ARG), NO_FL_ARG);
+                                               
+                                       Send_Notification(targ, MSG_ONE, MSG_DEATH, (targ.FRAG_VERBOSE ? DEATH_MURDER_TYPEFRAGGED_VERBOSE : DEATH_MURDER_TYPEFRAGGED),
+                                               s1, NO_STR_ARG, (targ.FRAG_VERBOSE ? attacker.health : NO_FL_ARG), (targ.FRAG_VERBOSE ? attacker.armorvalue : NO_FL_ARG), (targ.FRAG_VERBOSE ? ((clienttype(attacker) == CLIENTTYPE_BOT) ? BOT_PING : attacker.ping) : NO_FL_ARG));
+                               }
+                               else
+                               {
+                                       Send_Notification(attacker, MSG_ONE, MSG_DEATH, (attacker.FRAG_VERBOSE ? DEATH_MURDER_FRAG_VERBOSE : DEATH_MURDER_FRAG),
+                                               s2, NO_STR_ARG, attacker.killcount, (attacker.FRAG_VERBOSE ? ((clienttype(targ) == CLIENTTYPE_BOT) ? BOT_PING : targ.ping) : NO_FL_ARG), NO_FL_ARG);
+                                               
+                                       Send_Notification(targ, MSG_ONE, MSG_DEATH, (targ.FRAG_VERBOSE ? DEATH_MURDER_FRAGGED_VERBOSE : DEATH_MURDER_FRAGGED),
+                                               s1, NO_STR_ARG, (targ.FRAG_VERBOSE ? attacker.health : NO_FL_ARG), (targ.FRAG_VERBOSE ? attacker.armorvalue : NO_FL_ARG), (targ.FRAG_VERBOSE ? ((clienttype(attacker) == CLIENTTYPE_BOT) ? BOT_PING : attacker.ping) : NO_FL_ARG));
+                               }
+                               //if(DEATH_WEAPONOF(deathtype)) { Send_Notification(world, MSG_WEAPON, 50, s1, s2, attacker.killcount, targ.killcount, Obituary_Score_Position); }
+                               //else { Obituary_SpecialDeath(world, deathtype, s1, s2, attacker.killcount, targ.killcount, Obituary_Score_Position); }
                        }
-                       LogDeath("frag", deathtype, attacker, targ);
                }
        }
 
@@ -520,27 +544,27 @@ void Obituary(entity attacker, entity inflictor, entity targ, float deathtype)
        // =============
        else
        {
-               Send_CSQC_KillCenterprint(targ, "", "", deathtype, MSG_KILL_ACTION);
                if (deathtype == DEATH_HURTTRIGGER && inflictor.message != "")
                        msg = inflictor.message;
                else if (deathtype == DEATH_CUSTOM)
                        msg = deathmessage;
                else
                        msg = "";
-               if(strstrofs(msg, "%", 0) < 0)
-                       msg = strcat("%s ", msg);
+                       
+               if(strstrofs(msg, "%", 0) < 0) { msg = strcat("%s ", msg); }
 
+               LogDeath("accident", deathtype, targ, targ);
                GiveFrags(targ, targ, -1, deathtype);
                if(PlayerScore_Add(targ, SP_SCORE, 0) == -5) {
                        AnnounceTo(targ, "botlike");
                        PlayerStats_Event(attacker, PLAYERSTATS_ACHIEVEMENT_BOTLIKE, 1);
                }
-               Send_KillNotification(s, msg, "", deathtype, MSG_KILL_ACTION);
+               //Send_KillNotification(s, msg, "", deathtype, MSG_KILL_ACTION);
 
-               if (targ.killcount > 2)
-                       Send_KillNotification(s, ftos(targ.killcount), "", 0, MSG_KILL_ACTION_SPREE);
+               //if (targ.killcount > 2)
+               //      Send_KillNotification(s, ftos(targ.killcount), "", 0, MSG_KILL_ACTION_SPREE);
 
-               LogDeath("accident", deathtype, targ, targ);
+               Obituary_SpecialDeath(targ, FALSE, deathtype, s1, s2, f1, f2, NO_FL_ARG);
        }
 
        targ.death_origin = targ.origin;