Merge commit 'a764616a9c1b2f9148e3381f808b600c512592c9' into master-merge

[xonotic/netradiant.git] / libs / gtkutil / cursor.cpp

diff --git a/libs/gtkutil/cursor.cpp b/libs/gtkutil/cursor.cpp
index 46f227fce03c65ea49abf02e843481852a3acd52..e4d34b7d1607345ad734c6a362b3399969f48ae9 100644 (file)
--- a/libs/gtkutil/cursor.cpp
+++ b/libs/gtkutil/cursor.cpp
@@ -106,7 +106,6 @@ gboolean FreezePointer::motion_delta(ui::Widget widget, GdkEventMotion *event, F
 
                gdk_window_get_origin( gtk_widget_get_window( widget ), &window_x, &window_y);
 
-
                translated_x = current_x - ( window_x );
                translated_y = current_y - ( window_y );
 
@@ -159,11 +158,20 @@ gboolean FreezePointer::motion_delta(ui::Widget widget, GdkEventMotion *event, F
                        self->last_x = reposition_x;
                        self->last_y = reposition_y;
                }
+#else
+#if 0 // NetRadiantCustom
+               int ddx = current_x - self->center_x;
+               int ddy = current_y - self->center_y;
 #else
                int ddx = current_x - self->recorded_x;
                int ddy = current_y - self->recorded_y;
+#endif
                if (ddx < -32 || ddx > 32 || ddy < -32 || ddy > 32) {
+#if 0 // NetRadiantCustom
+                       Sys_SetCursorPos( widget, self->center_x, self->center_y );
+#else
                        Sys_SetCursorPos( widget, self->recorded_x, self->recorded_y );
+#endif
                        self->last_x = self->recorded_x;
                        self->last_y = self->recorded_y;
                }
@@ -173,7 +181,8 @@ gboolean FreezePointer::motion_delta(ui::Widget widget, GdkEventMotion *event, F
        return FALSE;
 }
 
-// Note: NetRadiantCustom pass both parent and widget.
+/* NetRadiantCustom did this instead:
+void FreezePointer::freeze_pointer(ui::Window window, ui::Widget widget, FreezePointer::MotionDeltaFunction function, void *data) */
 void FreezePointer::freeze_pointer(ui::Widget widget, FreezePointer::MotionDeltaFunction function, void *data)
 {
        /* FIXME: This bug can happen if the pointer goes outside of the
@@ -213,18 +222,41 @@ void FreezePointer::freeze_pointer(ui::Widget widget, FreezePointer::MotionDelta
        third-party updates that may fix the mouse pointer
        visibility issue. */
 #else
+#if 0 // NetRadiantCustom
        GdkCursor* cursor = create_blank_cursor();
        //GdkGrabStatus status =
+       /*      fixes cursor runaways during srsly quick drags in camera
+       drags with pressed buttons have no problem at all w/o this      */
+       gdk_pointer_grab( gtk_widget_get_window( widget ), TRUE, mask, 0, cursor, GDK_CURRENT_TIME );
+       //gdk_window_set_cursor ( GTK_WIDGET( window )->window, cursor );
+       /*      is needed to fix activating neighbour widgets, that happens, if using upper one */
+       gtk_grab_add( widget );
+       weedjet = widget;
+#else
+       GdkCursor* cursor = create_blank_cursor();
+       //GdkGrabStatus status =
        gdk_pointer_grab( gtk_widget_get_window( widget ), TRUE, mask, 0, cursor, GDK_CURRENT_TIME );
        gdk_cursor_unref( cursor );
+#endif
 #endif
 
        Sys_GetCursorPos( widget, &recorded_x, &recorded_y );
 
-       Sys_SetCursorPos( widget, recorded_x, recorded_y );
+#if 0 // NetRadiantCustom
+       /*      using center for tracking for max safety        */
+       gdk_window_get_origin( GTK_WIDGET( widget )->window, &center_x, &center_y );
+       auto allocation = widget.dimensions();
+       center_y += allocation.height / 2;
+       center_x += allocation.width / 2;
+
+       Sys_SetCursorPos( widget, center_x, center_y );
 
+       last_x = center_x;
+       last_y = center_y;
+#else
        last_x = recorded_x;
        last_y = recorded_y;
+#endif
 
        m_function = function;
        m_data = data;
@@ -243,9 +275,17 @@ void FreezePointer::unfreeze_pointer(ui::Widget widget)
        /* The pointer was visible during all the move operation,
        so, keep the current position. */
 #else
-       // Note: NetRadiantCustom still uses window instead of widget.
+       // NetRadiantCustom still uses window instead of widget.
+#if 0 // NetRadiantCustom
+//     Sys_SetCursorPos( widget, center_x, center_y );
+#else
        Sys_SetCursorPos( widget, recorded_x, recorded_y );
+#endif
 #endif
 
        gdk_pointer_ungrab( GDK_CURRENT_TIME );
+
+#if 0 // NetRadiantCustom
+       gtk_grab_remove( weedjet );
+#endif
 }